Skip to content

Feathers theme aware fixes#24719

Open
gagnus wants to merge 4 commits into
bevyengine:mainfrom
gagnus:feathers-theme-aware-fixes
Open

Feathers theme aware fixes#24719
gagnus wants to merge 4 commits into
bevyengine:mainfrom
gagnus:feathers-theme-aware-fixes

Conversation

@gagnus

@gagnus gagnus commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Objective

  • Developing a light theme I noticed a few bugs:
    • slider didn't recolor until mouse over
    • slider behind number input (when SoftLimit is used) had same issue
    • icons, including dialog close never recolor, made them take text color from theme
    • disclosure toggle recolored only when interacted with

Solution

  • Each had a slightly different fix. Disclosure toggle was setting colors directly when enabled/disabled, instead re-inserted InheritableThemeTextColor.
  • NumberInput needed a plugin to add an update function
  • Slider needed an update function
  • icons I added a new ThemedIcon component marker and a system to color that after text color has propagated (runs after propagation)

Testing

  • Tested all by switching theme in a local app. Should be zero change if you are not changing theme as bugs only show up when doing so.

gagnus added 2 commits June 22, 2026 22:37
…der itself, icon (uses text color). Added an icon_untinted, but its unused as everything I could see wanted the tint.
@viridia

viridia commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Note this will have a merge conflict with #24701

}

/// Re-apply the slidebar gradient colors for every number input when the theme changes.
fn update_slidebar_styles_theme(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw darn, I was hoping I could do the number input purely with observers - I wanted to see if it was possible. No such luck I guess :(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I was hunting around looking for the plugin! :)

@alice-i-cecile alice-i-cecile added this to the 0.20 milestone Jun 22, 2026
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jun 22, 2026
@alice-i-cecile alice-i-cecile enabled auto-merge June 22, 2026 22:58
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Jun 22, 2026
auto-merge was automatically disabled June 22, 2026 23:18

Head branch was pushed to by a user without write access

@alice-i-cecile alice-i-cecile enabled auto-merge June 22, 2026 23:37
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

3 participants