Downgrade gpu_readback closed-channel log from warn to debug#24707
Downgrade gpu_readback closed-channel log from warn to debug#24707PeteMichaud wants to merge 1 commit into
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
|
Context for me here is that I wanted to stop this from spamming my console and I realized that it was either a tiny change here that I believe everyone who uses readback would want, or some huge song and dance of forking or vendoring just this or something crazy. |
FYI you can filter logs :) Still, I agree with this downgrade! |
map_asynccallbacks inmap_buffersfire during wgpu's shutdown device-poll, afterGpuReadbacks(which owns the channel receivers) has already been dropped. Thetry_sendfails withClosed— expected, since the consumer is gone because the app is exiting. The same happens when aReadbackentity is intentionally despawned.This produces two
WARN bevy_render::gpu_readback: Failed to send readback result: ...lines on every app exit for any app usingReadback. The warning is never actionable.Downgrade to
debug!so the message is still available for diagnosis but doesn't pollute default log output.