Rename NextState::set_if_neq to set_if_different to resolve clashing#24676
Open
mansiverma897993 wants to merge 1 commit into
Open
Rename NextState::set_if_neq to set_if_different to resolve clashing#24676mansiverma897993 wants to merge 1 commit into
mansiverma897993 wants to merge 1 commit into
Conversation
kfc35
added
C-Bug
kfc35
added
D-Straightforward
alice-i-cecile
added
the
M-Migration-Guide
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
alice-i-cecile
requested changes
Jun 21, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Agreed that this needs renaming. Needs a migration guide though.
alice-i-cecile
added
S-Waiting-on-Author
mnmaita
approved these changes
Jun 21, 2026
mnmaita
left a comment
mnmaita
left a comment
Member
There was a problem hiding this comment.
Looks good to me (minus the missing migration guide as stated before). Thanks a lot!
| /// | ||
| /// This will run the state transition schedules [`OnEnter`](crate::state::OnEnter) and [`OnExit`](crate::state::OnExit). | ||
| /// If you want to skip those schedules for the same where we are transitioning to the same state, use [`set_if_neq`](Self::set_if_neq) instead. | ||
| /// If you want to skip those schedules when transitioning to the same state, use [`set_if_different`](Self::set_if_different) instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24655 by renaming NextState::set_if_neq to set_if_different to resolve clashing.