ImageMeasure border-box sizing fix#24674
Open
ickshonpe wants to merge 4 commits into
Open
Conversation
Added an `ImageMeasure` scene to testbed_ui for testing.
ickshonpe
added
C-Bug
ickshonpe
added
D-Straightforward
…honpe/bevy into image-measure-borderbox-fix
alice-i-cecile
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
On main (without the changes to the measure function in this PR) absolutely positioned nodes are sized to fit the image to their border-box not content-box:
(from the new
testbed_uiscene,ImageMeasureincluded with this PR). Only the 3rd and 6th image nodes in this layout were given any vertical padding, but extra vertical padding is given to all of the nodes except the first (which doesn't have a border so its border-box and content-box are the same size).Solution
Remove the known width guards from
ImageMeasure's border-box calculations:Testing