Skip to content

Solari: Make light tiles properly random#24670

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
JMS55:solari7-randomize-light-tiles
Jun 21, 2026
Merged

Solari: Make light tiles properly random#24670
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
JMS55:solari7-randomize-light-tiles

Conversation

@JMS55

@JMS55 JMS55 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Objective

  • Due to reusing the same constant in presample_light_tiles RNG as I used in the frame_index RNG, the light tiles were not properly random. Tile N+1 on frame X+1 would use the same pool of light as tile N on frame X - it was just "scrolling" each frame.

Solution

  • Use a different constant to properly randomize the pool

@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen labels Jun 19, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jun 19, 2026
@JMS55 JMS55 added this to the 0.20 milestone Jun 19, 2026
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 21, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 21, 2026
Merged via the queue into bevyengine:main with commit b257cc2 Jun 21, 2026
47 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants