Skip to content

Solari: Misc BRDF changes#24668

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
JMS55:solari7-misc-brdf
Jun 21, 2026
Merged

Solari: Misc BRDF changes#24668
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
JMS55:solari7-misc-brdf

Conversation

@JMS55

@JMS55 JMS55 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

  • Prevent NaNs from weird layering issues related to LUT precision by clamping the result of evaluate_brdf
  • Add EvaluateAndSampleBrdfResult.diffuse_selected which will be used in a future PR

@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen labels Jun 19, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Jun 19, 2026
Comment thread crates/bevy_solari/src/scene/brdf.wgsl
@JMS55 JMS55 added this to the 0.20 milestone Jun 19, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed D-Trivial Nice and easy! A great choice to get started with Bevy labels Jun 21, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 21, 2026
Merged via the queue into bevyengine:main with commit bde4e9d Jun 21, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants