Skip to content

Solari: Add DLSS-RR toggle to example #24667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 1 commit into from
Jun 22, 2026
+82 −24
Merged

Solari: Add DLSS-RR toggle to example #24667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 82 additions & 24 deletions examples/3d/solari.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ use rand::{RngExt, SeedableRng};
use std::f32::consts::PI;

#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))]
use bevy::anti_alias::dlss::{
Dlss, DlssProjectId, DlssRayReconstructionFeature, DlssRayReconstructionSupported,
use bevy::{
anti_alias::dlss::{
Dlss, DlssProjectId, DlssRayReconstructionFeature, DlssRayReconstructionSupported,
},
render::camera::{MipBias, TemporalJitter},
};

/// `bevy_solari` demo.
Expand Down Expand Up @@ -64,11 +67,13 @@ fn main() {
if args.pathtracer == Some(true) {
app.add_plugins(PathtracingPlugin);
} else {
#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))]
app.add_systems(Update, toggle_dlss_rr);

if args.many_lights != Some(true) {
app.add_systems(Update, (pause_scene, toggle_lights, patrol_path))
.add_systems(PostUpdate, update_control_text);
app.add_systems(Update, (pause_scene, toggle_lights, patrol_path));
}
app.add_systems(PostUpdate, update_performance_text);
app.add_systems(PostUpdate, (update_control_text, update_performance_text));
}

app.run();
Expand Down Expand Up @@ -351,6 +356,17 @@ fn setup_many_lights(
});
}

commands.spawn((
ControlText,
Text::default(),
Node {
position_type: PositionType::Absolute,
bottom: px(12.0),
left: px(12.0),
..default()
},
));

commands.spawn((
Node {
position_type: PositionType::Absolute,
Expand Down Expand Up @@ -443,6 +459,31 @@ fn add_raytracing_meshes_on_scene_load(
}
}

#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))]
fn toggle_dlss_rr(
key_input: Res<ButtonInput<KeyCode>>,
camera: Single<(Entity, Has<Dlss<DlssRayReconstructionFeature>>), With<SolariLighting>>,
dlss_rr_supported: Option<Res<DlssRayReconstructionSupported>>,
mut commands: Commands,
) {
if key_input.just_pressed(KeyCode::Digit3) && dlss_rr_supported.is_some() {
let (entity, dlss) = *camera;
if dlss {
commands
.entity(entity)
.remove::<(Dlss<DlssRayReconstructionFeature>, TemporalJitter, MipBias)>();
} else {
commands
.entity(entity)
.insert(Dlss::<DlssRayReconstructionFeature> {
perf_quality_mode: Default::default(),
reset: Default::default(),
_phantom_data: Default::default(),
});
}
}
}

fn pause_scene(mut time: ResMut<Time<Virtual>>, key_input: Res<ButtonInput<KeyCode>>) {
if key_input.just_pressed(KeyCode::Space) {
time.toggle();
Expand Down Expand Up @@ -531,37 +572,47 @@ fn update_control_text(
materials: Res<Assets<StandardMaterial>>,
directional_light: Query<Entity, With<DirectionalLight>>,
time: Res<Time<Virtual>>,
args: Res<Args>,
#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))] dlss_rr_supported: Option<
Res<DlssRayReconstructionSupported>,
>,
#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))] dlss_camera: Query<
Has<Dlss<DlssRayReconstructionFeature>>,
With<SolariLighting>,
>,
) {
text.0.clear();

if time.is_paused() {
text.0.push_str("(Space): Resume");
} else {
text.0.push_str("(Space): Pause");
}

if directional_light.single().is_ok() {
text.0.push_str("\n(1): Disable directional light");
} else {
text.0.push_str("\n(1): Enable directional light");
}
if args.many_lights != Some(true) {
if time.is_paused() {
text.0.push_str("(Space): Resume");
} else {
text.0.push_str("(Space): Pause");
}

match robot_light_material.and_then(|m| materials.get(&m.0)) {
Some(robot_light_material) if robot_light_material.emissive != LinearRgba::BLACK => {
text.0.push_str("\n(2): Disable robot emissive light");
if directional_light.single().is_ok() {
text.0.push_str("\n(1): Disable directional light");
} else {
text.0.push_str("\n(1): Enable directional light");
}
_ => {
text.0.push_str("\n(2): Enable robot emissive light");

match robot_light_material.and_then(|m| materials.get(&m.0)) {
Some(robot_light_material) if robot_light_material.emissive != LinearRgba::BLACK => {
text.0.push_str("\n(2): Disable robot emissive light");
}
_ => {
text.0.push_str("\n(2): Enable robot emissive light");
}
}
}

#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))]
if dlss_rr_supported.is_some() {
text.0
.push_str("\nDenoising: DLSS Ray Reconstruction enabled");
if matches!(dlss_camera.single(), Ok(true)) {
text.0.push_str("\n(3): Disable DLSS Ray Reconstruction");
} else {
text.0.push_str("\n(3): Enable DLSS Ray Reconstruction");
}
} else {
text.0
.push_str("\nDenoising: DLSS Ray Reconstruction not supported");
Expand All @@ -578,6 +629,10 @@ struct PerformanceText;
fn update_performance_text(
mut text: Single<&mut Text, With<PerformanceText>>,
diagnostics: Res<DiagnosticsStore>,
#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))] dlss_camera: Query<
Has<Dlss<DlssRayReconstructionFeature>>,
With<SolariLighting>,
>,
) {
text.0.clear();

Expand Down Expand Up @@ -610,7 +665,10 @@ fn update_performance_text(
"Specular indirect",
"render/solari_lighting/specular_indirect_lighting/elapsed_gpu",
);
(add_diagnostic)("DLSS-RR", "render/dlss_ray_reconstruction/elapsed_gpu");
#[cfg(all(feature = "dlss", not(feature = "force_disable_dlss")))]
if matches!(dlss_camera.single(), Ok(true)) {
(add_diagnostic)("DLSS-RR", "render/dlss_ray_reconstruction/elapsed_gpu");
}
text.push_str(&format!("{:17} {total:.2} ms\n", "Total"));

if let Some(world_cache_active_cells_count) = diagnostics
Expand Down