You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Assets<A> should have get_many / get_many_mut functions just like Query<...> does.
thats why I took the implementation of get_many_mut for Query as an inspiration.
i had to add an #[allow(unsafe_code)] above get_many_mut, so i want to know if thats permitted at that location
I added two unit tests for get_many_mut (since get_many is trivial), but ill happily write more if there are some edge cases i overlooked (unsafe code is scarry)
alice-i-cecile
added
C-Feature
A new feature, making something new possible
A-Assets
Load files from disk to use for things like images, models, and sounds
X-Contentious
There are nontrivial implications that should be thought through
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
D-Unsafe
Touches with unsafe code in some way
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Jun 4, 2025
i dont understand why the ci is failing now
i just merged 1 change from main into my pr, and havent touched the places where these errors get thrown now
it passed just fine before the merge
@Affinator with a little luck, we'll get #22939 in 0.20, and we'll get get_many for free through Query's implementation. I'll make sure to add that to the list of follow-up work for that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A-AssetsLoad files from disk to use for things like images, models, and soundsC-FeatureA new feature, making something new possibleD-ModestA "normal" level of difficulty; suitable for simple features or challenging fixesD-UnsafeTouches with unsafe code in some wayS-Needs-ReviewNeeds reviewer attention (from anyone!) to move forwardX-ContentiousThere are nontrivial implications that should be thought through
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16244
Assets<A>should have get_many / get_many_mut functions just likeQuery<...>does.thats why I took the implementation of get_many_mut for
Queryas an inspiration.i had to add an
#[allow(unsafe_code)]above get_many_mut, so i want to know if thats permitted at that locationthis pr also makes #16334 obsolete
Testing
I added two unit tests for get_many_mut (since get_many is trivial), but ill happily write more if there are some edge cases i overlooked (unsafe code is scarry)