Conversation
Despire
added
the
test-set-ordinary
Despire
added
test-set-autoscaling
WalkthroughThis update advances the supported Kubernetes and kubeone versions across code, documentation, and test manifests. Numerous test and manifest files now reference newer Ubuntu images and updated Kubernetes versions. Validation logic and related tests are aligned to accept only the newly supported Kubernetes versions. Image tags in container manifests were also updated. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ManifestValidator
participant Docs
participant TestSuite
User->>ManifestValidator: Submit manifest with Kubernetes version
ManifestValidator->>ManifestValidator: Validate version (must be 1.30.x, 1.31.x, 1.32.x)
ManifestValidator-->>User: Accept or reject manifest
User->>Docs: Read supported kubeone/Kubernetes versions
Docs-->>User: Display updated version info
TestSuite->>ManifestValidator: Run tests with updated versions/images
ManifestValidator-->>TestSuite: Return validation results
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
manifests/testing-framework/test-sets/proxy-without-hetzner/5.yaml (1)
25-25: Duplicate: Confirm image bump consistency Same update as inproxy-without-hetzner/8.yaml: please verify that switching toubuntu-2404-noble-amd64-v20250313is intentional and universally available.Also applies to: 38-38
manifests/testing-framework/test-sets/proxy-without-hetzner/9.yaml (1)
25-25: Duplicate: Confirm image bump consistency Same update as in other test sets: ensureubuntu-2404-noble-amd64-v20250313is the correct image variant and accessible in these regions.Also applies to: 38-38
manifests/testing-framework/test-sets/test-set4/2.yaml (1)
54-54: Duplicate: Confirm image bump consistency The images forgcp-kube-nodesandgcp-ldbl-nodeshave been updated toubuntu-2404-noble-amd64-v20250313. Please ensure these image IDs are correct and available in the target zones.Also applies to: 65-65
🧹 Nitpick comments (13)
manifests/testing-framework/test-sets/succeeds-on-last-2/3.yaml (1)
48-48: Quote version strings for consistency
Enclose version values in quotes (e.g.,"1.30.0") to maintain uniform YAML formatting across all manifests.manifests/testing-framework/test-sets/rolling-update-2/1.yaml (1)
113-113: Unify version formatting
Consider quoting the version value ("1.30.0") to match other manifests and ensure consistent YAML parsing.manifests/testing-framework/test-sets/succeeds-on-last-2/2.yaml (1)
49-49: Consistent YAML formatting
Consider quoting1.30.0("1.30.0") to maintain uniform style across manifests.services/kube-eleven/Dockerfile (1)
7-9: Add checksum verification for KubeOne download
Consider adding SHA256 checksum validation to the download step to guard against tampering:RUN KUBEONE_V=1.10.0 && \ wget -q https://github.com/kubermatic/kubeone/releases/download/v${KUBEONE_V}/kubeone_${KUBEONE_V}_linux_$TARGETARCH.zip && \ + echo "${KUBEONE_SHA256} kubeone_${KUBEONE_V}_linux_$TARGETARCH.zip" | sha256sum -c - && \ unzip -qq kubeone_${KUBEONE_V}_linux_$TARGETARCH.zip -d kubeone_dirYou'll need to pass
KUBEONE_SHA256as a build-arg.manifests/testing-framework/test-sets/test-set5/3.yaml (1)
61-61: Inconsistent Kubernetes version format
This manifest usesv1.30.0while other test-set manifests use unprefixed version strings (e.g.,1.30.0). Verify that thevprefix is accepted by the validation logic and aligns with the API spec.manifests/testing-framework/test-sets/succeeds-on-last-3/1.yaml (1)
39-39: Quote Kubernetes version string
Unquoted1.30.0may be interpreted as a float by some YAML parsers. Consider wrapping version values in quotes across manifests for consistency.manifests/testing-framework/test-sets/rolling-update/2.yaml (1)
99-99: Quote Kubernetes version string
Wrap1.30.0in quotes to ensure YAML parsers treat it as a string and maintain consistency with other manifests.manifests/testing-framework/test-sets/autoscaling-2/2.yaml (1)
63-63: Quote Kubernetes version string
Consider quoting1.31.0to prevent it from being parsed as a numeric value by YAML parsers.internal/manifest/validate.go (1)
86-88: Centralize supported Kubernetes versions
The list of supported versions appears in both the regex validator and this error message. Consider extracting it into a shared constant or function to avoid duplication and keep validation logic and messages in sync.manifests/testing-framework/test-sets/proxy-without-hetzner/6.yaml (1)
48-48: Suggest consistent quoting for version
The version is quoted here ("1.30.0"), while other manifests use an unquoted value. Consider standardizing the formatting across all YAML files.internal/manifest/validate_kubernetes.go (1)
17-17: Simplify version regex and update comment Consider replacing(30|31|32)with3[0-2]to reduce manual enumeration, and update the NOTE above to explicitly reference Kubernetes minor versions instead of kubeone.manifests/testing-framework/test-sets/test-set4/2.yaml (1)
70-70: Quote version value for consistency Theversion: 1.30.0field is unquoted here whereas other manifests use a quoted string. Wrap the version in quotes to avoid YAML parsing ambiguities.manifests/testing-framework/test-sets/test-set4/3.yaml (1)
60-60: Consider quoting the version string
For YAML consistency and to ensure it’s treated as a string, wrap the version (1.30.0) in quotes—e.g.,"1.30.0", as used in other manifests.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (54)
docs/input-manifest/api-reference.md(1 hunks)internal/manifest/validate.go(1 hunks)internal/manifest/validate_kubernetes.go(1 hunks)internal/manifest/validate_test.go(9 hunks)manifests/claudie/kustomization.yaml(1 hunks)manifests/testing-framework/kustomization.yaml(1 hunks)manifests/testing-framework/test-sets/autoscaling-1/1.yaml(3 hunks)manifests/testing-framework/test-sets/autoscaling-1/2.yaml(3 hunks)manifests/testing-framework/test-sets/autoscaling-1/3.yaml(2 hunks)manifests/testing-framework/test-sets/autoscaling-2/1.yaml(1 hunks)manifests/testing-framework/test-sets/autoscaling-2/2.yaml(1 hunks)manifests/testing-framework/test-sets/proxy-with-hetzner/5.yaml(1 hunks)manifests/testing-framework/test-sets/proxy-with-hetzner/6.yaml(1 hunks)manifests/testing-framework/test-sets/proxy-with-hetzner/7.yaml(1 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/1.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/10.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/2.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/3.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/4.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/5.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/6.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/7.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/8.yaml(2 hunks)manifests/testing-framework/test-sets/proxy-without-hetzner/9.yaml(2 hunks)manifests/testing-framework/test-sets/rolling-update-2/1.yaml(1 hunks)manifests/testing-framework/test-sets/rolling-update-2/2.yaml(1 hunks)manifests/testing-framework/test-sets/rolling-update/1.yaml(1 hunks)manifests/testing-framework/test-sets/rolling-update/2.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-1/1.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-1/2.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-2/1.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-2/2.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-2/3.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-3/1.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-3/2.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-4/1.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-4/2.yaml(1 hunks)manifests/testing-framework/test-sets/succeeds-on-last-4/3.yaml(2 hunks)manifests/testing-framework/test-sets/test-set1/1.yaml(4 hunks)manifests/testing-framework/test-sets/test-set1/2.yaml(4 hunks)manifests/testing-framework/test-sets/test-set2/1.yaml(2 hunks)manifests/testing-framework/test-sets/test-set2/2.yaml(2 hunks)manifests/testing-framework/test-sets/test-set2/3.yaml(2 hunks)manifests/testing-framework/test-sets/test-set3/1.yaml(3 hunks)manifests/testing-framework/test-sets/test-set3/2.yaml(1 hunks)manifests/testing-framework/test-sets/test-set3/3.yaml(1 hunks)manifests/testing-framework/test-sets/test-set3/4.yaml(1 hunks)manifests/testing-framework/test-sets/test-set4/1.yaml(1 hunks)manifests/testing-framework/test-sets/test-set4/2.yaml(2 hunks)manifests/testing-framework/test-sets/test-set4/3.yaml(1 hunks)manifests/testing-framework/test-sets/test-set5/1.yaml(1 hunks)manifests/testing-framework/test-sets/test-set5/2.yaml(1 hunks)manifests/testing-framework/test-sets/test-set5/3.yaml(1 hunks)services/kube-eleven/Dockerfile(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
manifests/testing-framework/kustomization.yaml (1)
Learnt from: Despire
PR: berops/claudie#1735
File: manifests/claudie/kustomization.yaml:59-61
Timestamp: 2025-06-10T08:04:36.596Z
Learning: In Claudie's deployment process, different images in the same kustomization.yaml file may have different tags intentionally. This is part of their e2e process where only relevant images are updated when changes propagate, rather than updating all images to the same tag. This selective updating approach is deliberate and not an inconsistency.
🔇 Additional comments (77)
manifests/testing-framework/kustomization.yaml (3)
5-5: Standardizeresourcesto a YAML list
Converted theresourcesfield into a proper YAML list for consistency with Kustomize schema.
8-89: RestructuresecretGeneratorinto list of maps
RefactoredsecretGeneratorentries into a YAML list where each item is a map withfilesandname, improving readability and conforming to Kustomize best practices.
92-94: Convertimagesto list of maps
Transformed theimagessection into a list format with explicitnameandnewTagfields, enhancing clarity and aligning with Kustomize conventions.manifests/claudie/kustomization.yaml (4)
3-15: Standardizeresourcesblock to YAML list
Converted theresourcesentries to a proper YAML list format with dashes, improving manifest readability and structure.
19-47: Reformatreplacementssection for clarity
Restructuredreplacementsinto a clear list of maps with well-indentedsource,targets,options, andselectkeys. No functional changes introduced.
50-55: FormatconfigMapGeneratoras a list of maps
EnsuredconfigMapGeneratorfollows Kustomize’s expected list-of-maps structure, with proper indentation forenvs,name, andoptions.
58-74: Convertimagesto list and update tags
Updated theimagessection to an explicit list withname/newTagentries reflecting the latest commit hashes. Per project conventions, different services may intentionally use distinct tags.manifests/testing-framework/test-sets/succeeds-on-last-1/2.yaml (1)
31-31: Bump Kubernetes version to 1.30.0
Updated the clusterversionto 1.30.0, aligning this test manifest with the PR’s new minimum supported Kubernetes version.manifests/testing-framework/test-sets/succeeds-on-last-2/1.yaml (1)
29-29: Bump Kubernetes version to 1.30.0
Aligned the test manifest’sversionfield with the updated minimum supported Kubernetes version (1.30.0).manifests/testing-framework/test-sets/succeeds-on-last-4/1.yaml (1)
29-29: Bump Kubernetes version to 1.30.0
Updated theversionto 1.30.0, matching the PR’s revised Kubernetes support range.manifests/testing-framework/test-sets/test-set5/2.yaml (1)
65-65: Confirm version bump and formatting consistency
The Kubernetes version is updated tov1.30.0, matching the new minimum supported version. However, other test manifests use bare numeric strings (e.g.,1.30.0) without thevprefix. Please confirm the expected version‐string convention and ensure the validation logic ininternal/manifest/validate_kubernetes.gohandles this format consistently.manifests/testing-framework/test-sets/autoscaling-2/1.yaml (1)
61-61: Confirm version bump and formatting consistency
The Kubernetes version is updated to1.31.0, aligning with the supported range. Note that this uses a bare numeric string, whiletest-set5uses avprefix. Please verify the desired convention for version fields and ensure the validator supports the chosen format across all manifests.manifests/testing-framework/test-sets/succeeds-on-last-1/1.yaml (1)
31-31: Confirm version bump and formatting consistency
The Kubernetes version is updated to1.30.0, which matches the new minimum version requirement. It’s specified without a leadingv, unlike intest-set5. Please confirm the canonical version format and adjust validation or manifest entries accordingly.manifests/testing-framework/test-sets/rolling-update-2/2.yaml (1)
56-56: Confirm version bump and formatting consistency
The Kubernetes version is updated to1.30.0(bare numeric). Ensure this aligns with the project’s version‐string policy, as some manifests include avprefix. Verify that the manifest validator correctly parses whichever format we settle on.manifests/testing-framework/test-sets/succeeds-on-last-4/2.yaml (1)
57-57: Confirm version bump and formatting consistency
The Kubernetes version is updated to1.30.0without a leadingv. Please confirm whether thevprefix should be retained or dropped in all test manifests, and ensure the validation logic is updated to accept the chosen style uniformly.manifests/testing-framework/test-sets/succeeds-on-last-2/3.yaml (1)
48-48: Consistent Kubernetes version bump
Kubernetes version updated to1.30.0aligns with the new minimum supported version. Ensure the validation logic ininternal/manifest/validate_kubernetes.gohas been updated accordingly.manifests/testing-framework/test-sets/rolling-update-2/1.yaml (1)
113-113: Kubernetes version alignment
Version bump to1.30.0matches the updated supported range. Confirm that the rolling-update tests and validation logic ininternal/manifest/validate.goaccept this version.manifests/testing-framework/test-sets/succeeds-on-last-2/2.yaml (1)
49-49: Kubernetes version updated
Bumped to1.30.0to match the new minimum supported Kubernetes version. Ensure this aligns withinternal/manifest/validate_kubernetes.goversion constraints.services/kube-eleven/Dockerfile (1)
7-7: KubeOne version bump to 1.10.0
UpdatingKUBEONE_Vto1.10.0aligns with the PR objective. Ensure corresponding documentation (api-reference.md) and any test fixtures reflect this change.manifests/testing-framework/test-sets/succeeds-on-last-3/1.yaml (1)
34-34: Ubuntu image version bump looks good
Updated image to the full Ubuntu 24.04 LTS server release, matching project-wide upgrades.manifests/testing-framework/test-sets/autoscaling-2/2.yaml (1)
63-63: Kubernetes version bumped to 1.31.0
This aligns with the updated validation logic that now supports 1.31.x.manifests/testing-framework/test-sets/proxy-with-hetzner/7.yaml (1)
47-47: GCP Ubuntu image version update approved
Upgraded compute node pool image toubuntu-2404-noble-amd64-v20250313, consistent with other test-set upgrades.manifests/testing-framework/test-sets/rolling-update/1.yaml (1)
99-99: Consistent Kubernetes version bump.The cluster version has been updated from 1.29.0 to 1.30.0 as intended.
Ensure this aligns with the updated validation rules invalidate_kubernetes.goand that corresponding tests cover this scenario.manifests/testing-framework/test-sets/succeeds-on-last-3/2.yaml (2)
34-34: Updated Azure VM image.The VM image reference has been bumped to
Canonical:ubuntu-24_04-lts:server:24.04.202502210.
Please verify that this image exists and is supported in the specified Azure region.
39-39: Bumped Kubernetes cluster version.The cluster version is now 1.30.0 to match PR objectives.
Confirm that related validation logic and test fixtures have been updated accordingly.manifests/testing-framework/test-sets/proxy-with-hetzner/6.yaml (1)
47-47: GCP compute node image upgrade.The GCP compute pool image has been updated to
ubuntu-2404-noble-amd64-v20250313.
Ensure this image is available ineurope-west1-band update any relevant documentation.manifests/testing-framework/test-sets/autoscaling-1/3.yaml (3)
34-34: Control node image updated.The control-plane node pool image is now
ubuntu-2404-noble-amd64-v20250313.
Validate that this image tag is correct and available on GCP.
45-45: Compute node image updated.Compute pool image bumped to
ubuntu-2404-noble-amd64-v20250313.
Confirm compatibility with the autoscaler settings.
51-51: Kubernetes version bump.Cluster version increment to 1.30.0 aligns with the updated support matrix.
Make sure test fixtures and validation rules reflect this change.manifests/testing-framework/test-sets/autoscaling-1/2.yaml (3)
34-34: Control node image bump.Updated control pool image to
ubuntu-2404-noble-amd64-v20250313.
Please verify this image tag in the GCP marketplace.
43-43: Compute node image bump.Compute pool image is now
ubuntu-2404-noble-amd64-v20250313.
Ensure it's available in the specified zone.
53-53: Updated Kubernetes version.Cluster version is upgraded to 1.30.0.
Validate alignment withvalidate_kubernetes.gologic and existing tests.manifests/testing-framework/test-sets/proxy-with-hetzner/5.yaml (1)
47-47: Align GCP image version with baseline
The updated image version matches the new Ubuntu 24.04 LTS server image used across other test sets.manifests/testing-framework/test-sets/proxy-without-hetzner/2.yaml (1)
25-25: Consistent Ubuntu image bump
The GCP node pool images have been updated to the new Ubuntu 24.04 LTS server image version, aligning with other test set manifests.Also applies to: 38-38
manifests/testing-framework/test-sets/test-set3/2.yaml (1)
44-44: Align Ubuntu image and Kubernetes version
The GCP compute node pool image and cluster version have been updated to the new Ubuntu 24.04 LTS server image and Kubernetes 1.30.0, consistent with validation updates.Also applies to: 50-50
manifests/testing-framework/test-sets/test-set4/1.yaml (1)
32-32: Update Kubernetes cluster version
The cluster version has been incremented to 1.30.0 to match the newly supported Kubernetes versions in the validation logic.manifests/testing-framework/test-sets/test-set3/4.yaml (2)
54-54: Approve Ubuntu image upgrade
Updated the GCP load balancer node pool to use the newer Ubuntu 24.04 LTS server image, consistent with other test sets.
60-60: Approve Kubernetes version bump
Cluster version updated to 1.30.0, matching the new minimum supported version.manifests/testing-framework/test-sets/succeeds-on-last-4/3.yaml (2)
43-43: Approve Azure image upgrade
Node pool image updated to the Canonical Ubuntu 24.04 LTS server edition, aligning with other manifests.
56-56: Approve Kubernetes version bump
Cluster version incremented to 1.30.0, in line with the new supported range.manifests/testing-framework/test-sets/autoscaling-1/1.yaml (3)
34-34: Approve control nodes image upgrade
Control node pool now uses Ubuntu 24.04 LTS server image, consistent across GCP pools.
45-45: Approve compute nodes image upgrade
Compute node pool image updated to Ubuntu 24.04 LTS server image, matching control pool.
55-55: Approve Kubernetes version bump
Cluster version set to 1.30.0, reflecting the updated minimum supported Kubernetes version.manifests/testing-framework/test-sets/proxy-without-hetzner/6.yaml (2)
25-25: Approve control nodes image upgrade
Control node pool now uses the Ubuntu 24.04 LTS server image, keeping consistency with other test sets.
38-38: Approve compute nodes image upgrade
Compute node pool updated to Ubuntu 24.04 LTS server image, aligned with control pool change.docs/input-manifest/api-reference.md (1)
410-410:Details
✅ Verification successful
Confirm updated kubeone documentation link
Ensure the referenced kubeone v1.10 compatibility page is correct and accessible.
🏁 Script executed:
#!/bin/bash # Verify the kubeone compatibility URL for v1.10 curl -I https://docs.kubermatic.com/kubeone/v1.10/architecture/compatibility/supported-versions/Length of output: 880
No action needed: kubeone v1.10 compatibility link is valid and accessible
The URL at docs.kubermatic.com/kubeone/v1.10/architecture/compatibility/supported-versions/ returns HTTP 200, so the reference is correct and working as expected.manifests/testing-framework/test-sets/proxy-without-hetzner/8.yaml (1)
25-25: Confirm image bump consistency The Ubuntu image has been updated from the minimal variant to the fullubuntu-2404-noble-amd64-v20250313for both control and compute pools. Please verify that this change is intentional across all test sets and that these images are available in the specified zones.Also applies to: 38-38
manifests/testing-framework/test-sets/test-set4/3.yaml (2)
54-54: Update GCP node pool image
Upgraded the GCP node pool to Ubuntu 24.04 LTS v20250313, aligning with the baseline image refresh across test sets.
60-60: Bump Kubernetes cluster version
The Kubernetes cluster version is now 1.30.0, matching the new minimum supported version for kubeone 1.10.manifests/testing-framework/test-sets/test-set2/1.yaml (3)
92-92: Update GCP LB node pool image
Switched the GCP load balancer node pool image to Ubuntu 24.04 LTS v20250313 to keep environments in sync.
140-140: Upgrade Kubernetes cluster version (Hetzner)
The Hetzner cluster version has been bumped to 1.30.0 to comply with the updated supported Kubernetes range.
148-148: Upgrade Kubernetes cluster version (OCI)
The OCI cluster version has been bumped to 1.30.0 in line with the new minimum supported version.manifests/testing-framework/test-sets/proxy-without-hetzner/3.yaml (2)
25-25: Update GCP control node pool image
Upgraded control nodes to Ubuntu 24.04 LTS v20250313 for consistency with other test sets.
38-38: Update GCP compute node pool image
Upgraded compute nodes to Ubuntu 24.04 LTS v20250313, aligning with the new image baseline.manifests/testing-framework/test-sets/proxy-without-hetzner/4.yaml (2)
25-25: Update GCP control node pool image
Updated the control plane image to Ubuntu 24.04 LTS v20250313, matching the standardized test environment.
38-38: Update GCP compute node pool image
Updated the compute plane image to Ubuntu 24.04 LTS v20250313 for consistency across manifests.manifests/testing-framework/test-sets/proxy-without-hetzner/10.yaml (2)
25-25: Update GCP control node pool image
Updated control nodes to Ubuntu 24.04 LTS v20250313, ensuring uniformity with other test sets.
38-38: Update GCP compute node pool image
Updated compute nodes to Ubuntu 24.04 LTS v20250313, reflecting the latest baseline image.manifests/testing-framework/test-sets/proxy-without-hetzner/7.yaml (3)
25-25: Approve image update for control nodes.
The Ubuntu image has been updated toubuntu-2404-noble-amd64-v20250313as per the PR objectives.
38-38: Approve image update for compute nodes.
The Ubuntu image has been updated toubuntu-2404-noble-amd64-v20250313matching the new baseline.
48-48: Approve Kubernetes version bump.
Cluster version set to1.30.0, aligning with the updated supported range.manifests/testing-framework/test-sets/test-set2/2.yaml (2)
101-101: Approve GCP LB node pool image update.
Load balancer nodes now referenceubuntu-2404-noble-amd64-v20250313, consistent with other test sets.
149-149: Approve Kubernetes version bumps.
Both Hetzner and OCI clusters have been updated to1.30.0, matching the newly supported versions.Also applies to: 157-157
manifests/testing-framework/test-sets/test-set3/3.yaml (2)
64-64: Approve GCP LB node pool image update.
Updated toubuntu-2404-noble-amd64-v20250313to align with the overall image version upgrade.
69-69: Approve Kubernetes version bump.
Cluster version raised to1.30.0to comply with the new supported range.internal/manifest/validate_test.go (3)
12-12: Approve testClusterVersionPass update.
testClusterVersionPassis now usingv1.30.0, reflecting the updated minimal supported version.
42-42: Approve TestProxy version updates.
All proxy-mode tests have been adjusted toVersion: "v1.30.0", matching the revised validation logic.Also applies to: 56-56, 70-70, 84-84, 98-98, 112-112, 126-126
168-168: Approve TestK8s patch-level version.
Version: "v1.30.2"correctly tests support for patch releases within the 1.30.x series.manifests/testing-framework/test-sets/proxy-without-hetzner/1.yaml (1)
25-25: Approve image updates for control and compute nodes.
Both node pools now useubuntu-2404-noble-amd64-v20250313, in line with other manifests.Also applies to: 38-38
manifests/testing-framework/test-sets/test-set2/3.yaml (2)
92-93: Update GCP load balancer image to full Ubuntu 24.04 LTS
The image forgcp-ldbl-nodeshas been upgraded from the minimal variant toubuntu-2404-noble-amd64-v20250313, aligning with the rest of the test sets.
140-141: Bump Kubernetes cluster versions to 1.30.0
Both Hetzner and OCI clusters have been updated to1.30.0. Ensure these versions are now accepted by the validation logic invalidate_kubernetes.go.Also applies to: 148-149
manifests/testing-framework/test-sets/test-set1/2.yaml (2)
106-107: Upgrade GCP control and compute node images
Control (e2-medium) and compute (e2-small) node pools now useubuntu-2404-noble-amd64-v20250313, matching the standardized LTS image.Also applies to: 119-120
206-207: Bump all Kubernetes cluster versions to 1.30.0
Every cluster in this test set has been updated to1.30.0. Verify that the updated version ranges invalidate_kubernetes.goand fixtures accommodate these minors.Also applies to: 214-215, 222-223, 232-233, 240-241
manifests/testing-framework/test-sets/test-set1/1.yaml (2)
107-108: Upgrade GCP control and compute node images
Node pools for GCP control and compute have been switched to the full Ubuntu 24.04 LTS image (ubuntu-2404-noble-amd64-v20250313).Also applies to: 117-118
207-208: Bump all Kubernetes cluster versions to 1.30.0
Cluster definitions now target1.30.0. Confirm that the new supported versions in the validation code and test fixtures align with this bump.Also applies to: 215-216, 223-224, 233-234, 241-242
manifests/testing-framework/test-sets/test-set3/1.yaml (2)
107-108: Upgrade GCP node images to Ubuntu 24.04 LTS
Control, compute, and load-balancer pools for GCP have been updated toubuntu-2404-noble-amd64-v20250313, replacing the minimal variant.Also applies to: 116-117, 126-127
133-134: Bump Kubernetes cluster versions to 1.30.0
Clustersts3-c-1andts3-c-2are now set to1.30.0. Ensure version validations invalidate_kubernetes.gopermit these minors under the new rules.Also applies to: 141-142
2 participants
Updates kubeone to the latest version 1.10.
Lowest allowed kuberentes version is now 1.30 and the latest supported version is 1.32
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores