fix: do not fail in initial migrations if PG_EXTRA_SEARCH_PATHS …#622
Open
zvolsky wants to merge 1 commit intobernardopires:masterfrom
Open
fix: do not fail in initial migrations if PG_EXTRA_SEARCH_PATHS …#622zvolsky wants to merge 1 commit intobernardopires:masterfrom
zvolsky wants to merge 1 commit intobernardopires:masterfrom
Conversation
Author
|
Please close the older related #542 |
Author
|
Seems this will be accepted never. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not fail in initial migrations if PG_EXTRA_SEARCH_PATHS is defined.
If we have empty database (like after DROP/CREATE DATABASE), the table for tenant model is not created yet and in old code all ./manage.py commands (like migrate_schemas) will fail. Worse: The error message is not very descriptive so it is not much easy find a workaround (which is temporary comment out PG_EXTRA_SEARCH_PATHS in settings).
This merge request should handle this so the code will run during initial migrations and no change in settings is needed.
In new code we just check if the (tenant) table exists in database.
Best regards,
Mirek