Set URL conf for PUBLIC_SCHEMA_URLCONF to avoid URL pattern duplication#604
Open
jibusayone wants to merge 1 commit intobernardopires:masterfrom
Open
Set URL conf for PUBLIC_SCHEMA_URLCONF to avoid URL pattern duplication#604jibusayone wants to merge 1 commit intobernardopires:masterfrom
jibusayone wants to merge 1 commit intobernardopires:masterfrom
Conversation
|
i'm using django-tenants, how can i request the same commit for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the docs, it's said that if we want the user to be routed to different views when someone requests http://example.com/ and http://customer.example.com/, we can specify that URL pattern in the
PUBLIC_SCHEMA_URLCONFfile.But if we want certain views to be available only when requested from public schema, currently we have to have those patterns in both
PUBLIC_SCHEMA_URLCONFandROOT_URLCONFfiles. And I had to then raisedjango.views.defaults.page_not_foundon theROOT_URLCONFpattern.To fix this duplicate pattern issue, I had to add
set_urlconf(request.urlconf)in the middleware.