fix: disable setup-node v5 auto-cache (pnpm not yet installed)#395
Merged
Conversation
qtipbera
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR unblocks #392 and needs an admin bypass.
actions/setup-node@v5introduced automatic package manager caching — when it detects apackageManagerfield inpackage.json, it tries to resolve and cache that package manager before any other steps run. Sincepnpm/action-setupruns AFTERsetup-node, pnpm isn't on PATH yet and the step fails with:This is a known v5 breaking change: actions/setup-node#1351
Fix: add
package-manager-cache: falseto allsetup-nodesteps. The workflow already has manualactions/cachesteps for the pnpm store, so the auto-cache is redundant anyway.@bearpong Same chicken-and-egg as the lockfile fix —
pull_request_targetruns main's workflow, so this needs an admin-bypass merge to unblock CI. One-line addition per job, no behavioral changes.