feat: Add sorting by Cost/Change column on account journal page#2255
Open
GuanghaoYe wants to merge 1 commit into
Open
feat: Add sorting by Cost/Change column on account journal page#2255GuanghaoYe wants to merge 1 commit into
GuanghaoYe wants to merge 1 commit into
Conversation
Make the "Cost / Change" column header clickable to sort journal entries by their change amount on the account page. The sort arrow indicator is placed on the left side to avoid overlapping with the right-aligned numeric text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the account journal page, the "Cost / Change" column header is now clickable to sort entries by their change amount (ascending/descending toggle). This follows the same
pattern used by the existing sortable columns (Date, Flag, Narration).
The sort arrow indicator is positioned on the left side of the header to avoid overlapping with the right-aligned numeric text.
Changes
frontend/src/reports/journal/sort.ts— add"change"column type and.changeCSS selectorfrontend/src/stores/journal.ts— add"change"to sort column validationfrontend/src/reports/journal/JournalHeaders.svelte— convert "Cost / Change" span to a sortable button with left-aligned arrow indicatorTesting
make lint— all checks passsvelte-check— 0 errors, 0 warnings/edit-example/account/Expenses/