chore: clean tests#290
Draft
jackchuma wants to merge 135 commits into
Draft
Conversation
Collaborator
🟡 Heimdall Review Status
|
…dd unexpectedMessageStatus flag, and streamline hash relay message logic.
…c and update init function visibility.
…ress instead of IOptimismPortal2, streamline message relay logic, and improve status mismatch handling.
… status mismatch handling by consolidating logic for unexpectedMessageStatus.
…tore gas calculation logic, and remove redundant comments in relay function.
…ccept l2SenderSlot parameter, enhancing flexibility in slot management during message relay.
…_MESSAGE_SIZE constant, streamline error handling by replacing reverted and unexpectedMessageStatus flags with a single badRelayResult flag, and simplify constructor parameters.
…clarity, update constructor and relay logic to improve readability, and enhance slot management in the init function.
…ults function with direct assertion in invariant tests for improved clarity and simplicity.
…ract, streamline setup logic, and enhance clarity in gas handling for safe calls.
… to improve invariant testing and clarify gas handling in safe calls.
…oving Vm dependency, update invariant comments for clarity, and streamline gas handling logic in invariant tests.
…t harness address and failure expectation, rename performSafeCallMinGas to callWithMinGas for clarity, and improve gas handling logic in safe calls.
…by replacing repetitive assertions with helper functions, improving readability and maintainability of test cases.
…ucing helper functions for game initialization and assertion, enhancing code readability and maintainability.
… balance management, streamline balance assertions with a new internal function, and enhance clarity in test cases by reducing redundancy in balance checks.
…nternal helper functions for assertion checks, enhance clarity in test cases by reducing redundancy, and improve maintainability in the test structure.
…g in delegate calls by using calldata, streamline gas burning logic with a constant overhead, and enhance clarity by removing redundant internal functions.
…nts with references to Constants, streamline admin and implementation management functions for improved clarity and maintainability.
…evelopment registry, emphasizing that it allows signer registration without Nitro attestation verification, and streamline comments for improved readability.
…ance variable visibility by making them private, and clarify comments regarding storage slot usage for improved understanding of upgrade behavior.
…larity, consolidate fee vault assertions into a helper function, and enhance readability by removing redundant comments.
…d balances with a constant, and improve function visibility for better maintainability and clarity in test setup.
…ract, enhancing clarity and maintainability in the event definitions.
…nt functions, update SystemConfig interaction, and clarify contract documentation for improved maintainability and clarity in feature checks.
…troducing helper functions for command generation and argument setting, enhancing code clarity and maintainability in transaction input handling.
…ependency, streamline upgrade logic by consolidating function parameters, and enhance clarity in contract documentation for improved maintainability.
…is setup by utilizing DeployUtils for etching, and enhance clarity in contract documentation regarding test setups and configurations.
…t value, and enhance input validation in incrementPayable function by requiring a positive value for transactions.
…ity by introducing immutable variables for improved gas efficiency, streamline nonce handling with a dedicated function, and improve clarity in assertions for message status checks.
…ntroducing helper functions for clarity, enhance assertion checks for system pause state, and improve function visibility for better maintainability.
…ct balance assertion message, and enhance signature handling with dedicated helper functions for improved clarity and maintainability.
…assertions by introducing helper functions for L2 call verification, enhance clarity in test logic, and improve consistency in handling single and multiple L2 calls.
… minting to streamline test logic, enhance clarity in assertions, and remove redundant code for improved maintainability.
…remote token address revert message, rename test functions for clarity, and streamline assertions for improved readability and maintainability.
…functions for implementation management, enhance clarity in assertions, and improve maintainability by removing redundant code and constants.
… for improved readability, streamline setup logic by enhancing clarity in ownership management, and consolidate assertion methods for better maintainability.
…per functions for managing ResolvedDelegateProxy slots, enhance clarity in assertions, and improve maintainability by streamlining setup logic.
…ns to external, streamline constructor tests by directly asserting initialization values, and enhance clarity in test logic for improved maintainability.
…ces, replace hardcoded addresses with constants for improved readability, and streamline assertions in test cases for better maintainability.
…98 implementation directly, introduce a helper function for deposit logic, and enhance test clarity by reducing redundancy in deposit calls.
…tions, enhance error handling in delegate calls, and improve clarity in test assertions for better maintainability.
…roved clarity and maintainability.
…onsolidating calldata assignments, remove redundant comments for improved clarity, and enhance maintainability of test setup logic.
…ate initialization logic for FeeVault contracts, and enhance test assertions to ensure proper initialization behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.