docs: fix duplicate words and 'subwrod' typos in cannon NatSpec#285
Closed
0xAxiom wants to merge 1 commit into
Closed
docs: fix duplicate words and 'subwrod' typos in cannon NatSpec#2850xAxiom wants to merge 1 commit into
0xAxiom wants to merge 1 commit into
Conversation
- src/cannon/MIPS64.sol: 'the the subword' -> 'the subword'; 'subwrod' -> 'subword' - src/cannon/libraries/MIPS64Instructions.sol: 'the the subword' -> 'the subword'; 'subwrod' -> 'subword' Comment-only changes; no behavior change.
Collaborator
🟡 Heimdall Review Status
|
Author
|
Closing: the files modified in this PR (src/cannon/MIPS64.sol and src/cannon/libraries/MIPS64Instructions.sol) were removed in upstream PR #284 (chore: rm fault proofs). Changes no longer applicable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment/NatSpec-only fixes for typos that have been sitting in the cannon files since their introduction:
src/cannon/MIPS64.sol—loadSubWordNatSpec:the the subword→the subword;subwrod→subwordsrc/cannon/libraries/MIPS64Instructions.sol—selectSubWordNatSpec:the the subword→the subword;subwrod→subwordRebased on current main (removed the
DeployOPChain.s.solchange since that file was deleted upstream).No behavior change — comment-only fixes.