Fix unsetMethod handling for camelCase methods#1780
Open
Dayoebe wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
unsetMethod()so it can correctly remove generated methods regardless of the casing used when calling it.Currently,
setMethod()stores method names using their original casing, whileunsetMethod()tries to remove the lowercase version of the method name. Because of this, callingunsetMethod('newModelQuery')does not remove the generatednewModelQuerymethod.This update makes
unsetMethod()compare method names case-insensitively while still unsetting the actual stored key.Fixes #1381.
Type of change
Checklist
composer fix-style