Fix invalid phpdoc for casted property without return (#1236)#1264
Open
edgardmessias wants to merge 1 commit into
Open
Fix invalid phpdoc for casted property without return (#1236)#1264edgardmessias wants to merge 1 commit into
edgardmessias wants to merge 1 commit into
Conversation
mfn
requested changes
Oct 12, 2021
mfn
left a comment
mfn
left a comment
Collaborator
There was a problem hiding this comment.
I think we've good coverage and test-ability for this code in general, do you think you can add a test showing this?
Author
|
Yes, I can try add some test for this case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix invalid phpdoc for casted property without return type
Type of change
Checklist
composer fix-style