Skip to content

Bumps to 0.7.0 - #194

Open
barrettotte wants to merge 5 commits into
masterfrom
barrettotte/0.7.0-bump
Open

Bumps to 0.7.0#194
barrettotte wants to merge 5 commits into
masterfrom
barrettotte/0.7.0-bump

Conversation

@barrettotte

@barrettotte barrettotte commented Jul 29, 2026

Copy link
Copy Markdown
Owner
  • PRs 184-192 filled some grammar gaps and added a bunch of grammar tests
  • PR 193 adds COBOL support edit: removed in favor of bitlang.cobol in the IBM i development pack
  • Overall the goal was to do a 2026 refresh on this repo which I should have done years ago

@barrettotte

barrettotte commented Jul 29, 2026

Copy link
Copy Markdown
Owner Author

@chrjorgensen and @richardm90 if you happen to have some spare time/energy (no worries if not) and access to a seasoned IBM i system, please try browsing through some source (RPGLE, RPG, CL, DDS, PNLGRP, etc.) in vscode debug using this branch (or master) and see if any obvious regressions are present. If there are, please open an issue and I'll fix it. I'll probably be looking to release 0.7.0 (0.7.x since there were so many changes) on Friday or Saturday night (EST).

I ran through all the previous tests (now in tests/legacy/) and made sure valid tests still highlighted correctly as it did in the past. However, I was unaware I had a couple invalid mixed format RPGLE samples that I built the grammar off of. So I used IBM i docs and the info from #169 to handle the fixed vs **free vs mixed (/FREE, /END-FREE) issues

I also fixed #182 (found in PR #169), #181 (found in PR #169), #168, and #167 as part of the overall refresh / grammar gaps

@richardm90

Copy link
Copy Markdown
Collaborator

@barrettotte , apologies, I've been tied up all week, I'll take a look this coming week.

@richardm90

Copy link
Copy Markdown
Collaborator

@barrettotte , I just had a quick look to see if there were any immediate issues and VS Code did throw an error when I ran the master branch in debug. There is a conflict between the COBOL extension I have installed and this repo. I didn't specifically install the bitlang.cobol extension and I rarely view COBOL code but the bitlang.cobol extension is installed as part of the IBM i development pack, which most users will have installed too. I'll continue testing the various example files we had but wanted to give you a heads up.

@barrettotte

barrettotte commented Aug 2, 2026

Copy link
Copy Markdown
Owner Author

@barrettotte , I just had a quick look to see if there were any immediate issues and VS Code did throw an error when I ran the master branch in debug. There is a conflict between the COBOL extension I have installed and this repo. I didn't specifically install the bitlang.cobol extension and I rarely view COBOL code but the bitlang.cobol extension is installed as part of the IBM i development pack, which most users will have installed too. I'll continue testing the various example files we had but wanted to give you a heads up.

Ah I didn't think about that all, I haven't had the IBM i development pack installed for a while. Maybe I'll back out this repo's COBOL or deactivate it. Going to look into that.

Thanks that's a great catch that would have probably annoyed a lot of people

edit: will most likely remove my COBOL, I did not realize that bitlang.cobol had ILE COBOL support. Woops

@richardm90 richardm90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barrettotte , there's a lot in this release. .snap files are new to me so I've performed some spot checks on a range of test files and all worked well.

The only minor change I can suggest is a typo in CHANGELOG.md - says stirng instead of string.

I'm sure I'll need to pick your brains if I need to change any of the syntax files or fixtures.

Excellent work!

@barrettotte

Copy link
Copy Markdown
Owner Author

@richardm90 Yeah I'm new to them as well; .snap files are a little cumbersome, but seemingly the most straightforward way to catch side effects or regressions from grammar updates. Hopefully they can save time and reduce the tedium from visually inspecting the test files

Thanks for taking a look, I really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants