Fix Windows FFmpeg pkg-config paths#10771
Open
tangkelu wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows FFmpeg pkg-config metadata so
PkgConfig::LIBAVdoes not expose relative include paths.Problem
The installed FFmpeg
.pcfiles on Windows can contain a relative prefix likeprefix=./dist, which causespkg-configto return relative paths such as./dist/include.Those paths are propagated into
PkgConfig::LIBAV, and CMake then fails while configuringlibslic3r_guibecauseINTERFACE_INCLUDE_DIRECTORIEScontains a relative path.Fix
.pcfiles on Windows to use the actual installed prefixPkgConfig::LIBAVinsrc/slic3r/CMakeLists.txtResult
Windows desktop builds no longer fail at configure time due to relative FFmpeg pkg-config include paths.