Pass max_block_size and EXPLAIN settings via the protocol, not SETTINGS clause#263
Merged
Conversation
…GS clause execute_for_each() appended "SETTINGS max_block_size=8192" to the SQL, which produced a duplicate SETTINGS clause for queries that already carry their own (stack_traces_for_perfetto's allow_introspection_functions=1). Use the driver's new per-query Query::with_setting() so the block-size cap rides the native protocol and composes with any in-SQL SETTINGS. explain() had the same shape: it appended the query's settings as a SETTINGS clause onto original_query, which can already end with SETTINGS — the duplicate is dropped from EXPLAIN SYNTAX output. Pass those settings through the protocol too (execute() now takes impl Into<Query>), as the old NOTE suggested. get_query() no longer detects an existing SETTINGS clause to merge into: ClickHouse accepts multiple SETTINGS clauses, so it always appends its own. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_for_each() appended "SETTINGS max_block_size=8192" to the SQL, which produced a duplicate SETTINGS clause for queries that already carry their own (stack_traces_for_perfetto's allow_introspection_functions=1). Use the driver's new per-query Query::with_setting() so the block-size cap rides the native protocol and composes with any in-SQL SETTINGS.
explain() had the same shape: it appended the query's settings as a SETTINGS clause onto original_query, which can already end with SETTINGS — the duplicate is dropped from EXPLAIN SYNTAX output. Pass those settings through the protocol too (execute() now takes impl Into), as the old NOTE suggested.
get_query() no longer detects an existing SETTINGS clause to merge into: ClickHouse accepts multiple SETTINGS clauses, so it always appends its own.