chore: change visibility of binary fuse descriptor - #97
Open
leiysky wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Makes the BinaryFuse{8,16,32} filter descriptor publicly accessible, aligning its visibility with the already-public fingerprints field so callers can inspect (and now also construct) full filter state.
Changes:
- Change
descriptorfield visibility from private topubinBinaryFuse8,BinaryFuse16, andBinaryFuse32. - Add a doc comment describing the purpose of the descriptor field.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bfuse8.rs | Exposes BinaryFuse8.descriptor publicly and documents it. |
| src/bfuse16.rs | Exposes BinaryFuse16.descriptor publicly and documents it. |
| src/bfuse32.rs | Exposes BinaryFuse32.descriptor publicly and documents it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ayazhafiz
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is, since
fingerprintsis already public.