Skip to content

fix: address security scanners follow-up items (#180)#199

Merged
leandrodamascena merged 5 commits intomainfrom
fix/security-scanners-followup-180
Apr 21, 2026
Merged

fix: address security scanners follow-up items (#180)#199
leandrodamascena merged 5 commits intomainfrom
fix/security-scanners-followup-180

Conversation

@scottschreckengaust
Copy link
Copy Markdown
Member

Summary

Addresses all three follow-up items from issue #180 (security scanners PR #161 review).

Changes

1. Fix concurrency group descriptions in admin guide

docs/ADMINISTRATIVE_GUIDE.md — updated all three workflow reference tables from
{workflow}-{ref} to {workflow}-{event_name}-{ref} to match the actual implementation
(changed in 0a2da23 to prevent push events from cancelling scheduled scans).

2. Document ClamAV digest update cadence and update digest

  • Replaced the TODO in the "Updating Pinned Versions" section with complete instructions:
    • Update cadence table (quarterly for actions/scanners, monthly for ClamAV)
    • How to look up GitHub Actions commit SHAs
    • How to get the latest ClamAV linux/amd64 digest
    • How to check scanner tool versions (PyPI, GitHub releases)
    • Verification steps after updating
  • Updated the ClamAV image digest in security-scanners.yml to current latest

3. Add inline comment for sudo rm -f workaround

Added # prevent man-db auto-update from blocking apt-get to the ClamAV job's
sudo rm -f /var/lib/man-db/auto-update line.

Checklist

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Test Plan

  • Verified npx markdownlint-cli2 "docs/ADMINISTRATIVE_GUIDE.md" passes with 0 errors
  • Confirmed ClamAV digest is the current linux/amd64 platform digest via docker buildx imagetools inspect
  • Concurrency group strings verified against all workflow files

Closes #180


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

- Fix concurrency group descriptions in admin guide to match actual
  {workflow}-{event_name}-{ref} pattern
- Update ClamAV image digest to current latest (linux/amd64)
- Add inline comment explaining sudo rm -f man-db workaround
- Replace TODO in Updating Pinned Versions with real instructions
  including monthly ClamAV cadence, GitHub Actions SHA lookup,
  scanner version sources, and verification steps

Closes #180
@github-actions github-actions Bot added documentation Improvements or additions to documentation github labels Apr 20, 2026
Copy link
Copy Markdown
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scottschreckengaust, I left a comment. I saw that you're making changes to the administrative guide to maintain a consistent cadence in updating dependencies, but at the same time you're submitting a PR to resolve the issue with Dependabot. So, should we maintain this consistency using only Dependabot?

Comment thread docs/ADMINISTRATIVE_GUIDE.md Outdated
Dependabot (PR #200) will handle automated version updates,
making manual update instructions unnecessary.
Copy link
Copy Markdown
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Kalindi-Dev Kalindi-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@scoropeza scoropeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandrodamascena leandrodamascena added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit a756b71 Apr 21, 2026
21 checks passed
@leandrodamascena leandrodamascena deleted the fix/security-scanners-followup-180 branch April 21, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: follow-up items from security scanners PR #161

4 participants