fix(rds): properly handle RETAIN_ON_UPDATE_OR_DELETE in subresources#38331
Open
wasim-builds wants to merge 1 commit into
Open
fix(rds): properly handle RETAIN_ON_UPDATE_OR_DELETE in subresources#38331wasim-builds wants to merge 1 commit into
wasim-builds wants to merge 1 commit into
Conversation
github-actions
Bot
added
beginning-contributor
aws-cdk-automation
requested changes
Jul 16, 2026
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37780. Updated
helperRemovalPolicyanddefaultDeletionProtectionto properly handleRemovalPolicy.RETAIN_ON_UPDATE_OR_DELETErather than collapsing it. Also updatedserverless-cluster.tsto usehelperRemovalPolicy.