chore(lab): migrate IDE tool installation to mise#1839
Open
lucerobr wants to merge 1 commit intoaws-samples:mainfrom
Open
chore(lab): migrate IDE tool installation to mise#1839lucerobr wants to merge 1 commit intoaws-samples:mainfrom
lucerobr wants to merge 1 commit intoaws-samples:mainfrom
Conversation
Replace custom shell-based binary downloads in installer.sh with mise for declarative tool version management. This removes the custom Renovate regex manager for installer.sh and replaces it with native mise manager support. Tools migrated to mise.toml: - kubectl, helm, eksctl, yq, flux2, argocd, terraform (short names) - oha, kubeseal, ec2-instance-selector (github: backend) Remaining in installer.sh (no mise backend available): - AWS CLI v2 - awscurl, git-remote-s3 (pip packages) Renovate changes: - Add mise to enabledManagers - Remove installer.sh custom regex manager - Update IDE binaries group to match lab/mise.toml - Add extractVersion overrides for github: backend tools - Extend automerge rule to cover mise manager Fixes aws-samples#1805
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1805
What this PR does
Replaces custom shell-based binary downloads in
installer.shwith mise for declarative tool version management. This removes the custom Renovate regex manager forinstaller.shand replaces it with native mise manager support.Tools migrated to
lab/mise.tomlkubectl,helm,eksctl,yq,flux2,argocd,terraform(registered short names)oha,kubeseal,ec2-instance-selector(github: backend)Remaining in
installer.shawscurl,git-remote-s3— pip packagesRenovate changes
misetoenabledManagersinstaller.shcustom regex managerlab/mise.tomlextractVersionoverrides forgithub:backend toolsQuality checks
make test module="introduction"it was successfulNotes
github:backend tools duringdocker build, which makes unauthenticated GitHub API calls. CI environments withGITHUB_TOKENavailable will not hit rate limits.kubectlversion constraint inrenovate.json(pinned to 1.33.x) is preserved.--allowerasingadded to the initialyum installto resolve acurlvscurl-minimalpackage conflict on Amazon Linux 2023 base image.