As Glue limits comments to 255 characters, we may need to truncate them#174
Merged
moomindani merged 3 commits intoaws-samples:masterfrom May 23, 2025
Merged
As Glue limits comments to 255 characters, we may need to truncate them#174moomindani merged 3 commits intoaws-samples:masterfrom
moomindani merged 3 commits intoaws-samples:masterfrom
Conversation
moomindani
approved these changes
May 23, 2025
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to merge the original pull request (#38).
Changes added in #38:
Changes added in this PR:
Tests:
Tests are written in this comment
Additional test for partition key:
Steps:
Results:
With the change in #38, the job failed with this message. (failed at
table.partitionKeys.1.member.comment)With this change, the job succeeded and the comment on partition key is also truncated.