Skip to content

chore(maintenance): remove DOM lib, use undici-types for fetch types #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svozza wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(maintenance): remove DOM lib, use undici-types for fetch types #5351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3abe4b
chore(maintenance): remove DOM lib, use undici-types for server-side …
svozza Jun 13, 2026
b3416a0
chore(maintenance): declare undici-types as explicit root devDependency
svozza Jun 13, 2026
07c0d40
chore(maintenance): drop stale comment on undici-types import
svozza Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/snippets/event-handler/http/advanced_fine_grained_responses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ app.get('/todos', async () => {
});

app.post('/todos', async ({ req }) => {
const body = await req.json();
const body = (await req.json()) as { title: string };

@dreamorosi dreamorosi Jun 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind having these in the snippets, but I'm mildly concerned about the implications that these new types have on end customers.

Does this mean customers who use the library now have to do this cast every time they use this?

@svozza svozza Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point, there will be effects on customer. If you are doing stuff like req.json() in middleware or a handler like in this example, you would need to fix the types with a cast now that you are not getting Promise<any> back. I'm not sure that's a bad thing though, because it makes clear that you are handling untrusted data. Ultimately if you want real safety guarantees you should really be using a validation library like Zod and this problem goes away. That said, this does feel quite disruptive so I'm open to persuasion that we should leave things as they are.

@dreamorosi dreamorosi Jun 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me take it for a spin and see how it works in practice before I insist further in either way.

const todo = await createTodo(body.title);

return new Response(JSON.stringify(todo), {
Expand Down
4 changes: 3 additions & 1 deletion examples/snippets/parameters/customProviderVault.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ class HashiCorpVaultProvider extends BaseProvider {
if (!res.ok) {
throw new GetParameterError(`Failed to fetch secret ${res.statusText}`);
}
const response = await res.json();
const response = (await res.json()) as {
data: { data: Record<string, unknown> };
};
return response.data.data;
}

Expand Down
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
"typedoc": "^0.28.19",
"typedoc-plugin-missing-exports": "^4.1.3",
"typescript": "^6.0.3",
"undici-types": "^7.24.6",
Comment thread
dreamorosi marked this conversation as resolved.
"vitest": "^4.1.2"
},
"lint-staged": {
Expand Down
1 change: 1 addition & 0 deletions packages/event-handler/src/http/converters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import type {
APIGatewayProxyResult,
APIGatewayProxyStructuredResultV2,
} from 'aws-lambda';
import type { BodyInit } from 'undici-types';
import type {
ExtendedAPIGatewayProxyResult,
ExtendedAPIGatewayProxyResultBody,
Expand Down
3 changes: 2 additions & 1 deletion packages/event-handler/tests/e2e/httpRouter.test.FunctionCode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { JSONValue } from '@aws-lambda-powertools/commons/types';
import { Router } from '@aws-lambda-powertools/event-handler/http';
import type { Context } from 'aws-lambda';
import { binaryRouter } from './routers/binaryRouter.js';
Expand Down Expand Up @@ -27,7 +28,7 @@ const app = new Router()

// Request body parsing and headers
app.post('/echo', async ({ req }) => {
const body = await req.json();
const body = (await req.json()) as JSONValue;
const contentType = req.headers.get('content-type');
const customHeader = req.headers.get('x-custom-header');
const multiHeader = req.headers.get('x-multi-header');
Expand Down
Loading
Loading