allow accessing entity from intersections callback#966
Open
PROMETHIA-27 wants to merge 2 commits into
Open
Conversation
Jondolf
approved these changes
Mar 28, 2026
Member
Jondolf
left a comment
There was a problem hiding this comment.
Thanks, LGTM once CI passes. Looks like a trivial error with a doc test missing the parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Adds a new parameter to the callback in
MoveAndSlide::intersections, to allow accessing the intersected entity.Solution
Adds a new parameter to the relevant callback.
Testing
The change is extremely simple so as long as the logic is correct, it shouldn't need extensive testing.
I ran
cargo testto try and catch all places that needed to be updated in the repo, and use the same logic in a vendored version of the function in a project and it has worked correctly so far.I did see 4 failures in the
cargo testbut they seemed to be minor precision issues; float equality comparisons off by 0.0001 or so. Probably unrelated to the changes in this PR.