Conversation
Related Issue: #6663
This commit creates (hopefully) all the controllers, models, and views for the new Units structure. Initial code for the Units is copied from the Admin::Collection model and given some tweaking. Tests are not passing in the work for this commit. TODO: Properly map hierarchy of permissions for Unit. Do managers, editors, depositors have permissions to do anything to the Unit or are they only relevant for being assigned to child collections? If they do have permissions, how do they differ from the new unit administrator role?
This commit reworks collections to belong_to a Unit. Is this the approach that should be taken? This would require a large effort data remediation to create Unit entries for all existing units in a repository and making sure that all collections are assigned to the proper new Unit, while retaining all the current permissions structures. Is there a way to have both the modelled Units and the controlled vocab based units exist alongside each other to ease the remediation burden?
This commit effectively copies and tweaks the collections ability checks over to the Units. There will need to be a conversation on if these changes are all that is necessary.
…ns for updating pulling unit name from the RDF
Update ffmpeg_presets.yml
Refactor SupplementalFile#attach_file
Related issue: #6812
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
Allow accessibility exemption in batch manifest
Escape solr query in uniqueness validator
Use @samvera/rampv5.1.0 in the package.json for 8.2
Return unit id and name in media object json, not whole unit
Fix AJAX save for master file form in file-upload step
* Show a11y compliance exemption on item view page * Remove accessibility compliance section in manage files * Code review: remove additional route, fix AJAX and tests accordingly * Fix failing test * Code review: remove duplicated save, use a11y override setting to display toggle * Fix failing feature spec
Related issue: #6081 Fedora requests were being made on all action types for supplemental file controller and the show action of the objects controller. This commit adds a `fetch_proxy` method so we can retrieve object proxies for any controller actions that do not require a save, reducing unnecessary calls to fedora.
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
We don't use the coverage numbers anymore so it doesn't need to happen on each CI run.
Most tests are independent of each other but a number are still order dependant but should have comments indicating so. Some fixes to controller and view code included in order for tests to pass.
joncameron
self-requested a review
May 13, 2026 19:21
joncameron
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.