Skip to content

refactor: make Postgres GC preemptible via per-batch xact locks #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
josephschorr wants to merge 1 commit into
base: main
Choose a base branch
from

refactor: make Postgres GC preemptible via per-batch xact locks

d5a1a83
Select commit
Loading
Failed to load commit list.
Draft

refactor: make Postgres GC preemptible via per-batch xact locks #3059

refactor: make Postgres GC preemptible via per-batch xact locks
d5a1a83
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 3, 2026 in 1s

59.16% of diff hit (target 73.80%)

View this Pull Request on Codecov

59.16% of diff hit (target 73.80%)

Annotations

Check warning on line 115 in internal/datastore/mysql/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/mysql/gc.go#L114-L115 

Added lines #L114 - L115 were not covered by tests

Check warning on line 118 in internal/datastore/mysql/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/mysql/gc.go#L117-L118 

Added lines #L117 - L118 were not covered by tests

Check warning on line 122 in internal/datastore/mysql/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/mysql/gc.go#L121-L122 

Added lines #L121 - L122 were not covered by tests

Check warning on line 153 in internal/datastore/mysql/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/mysql/gc.go#L152-L153 

Added lines #L152 - L153 were not covered by tests

Check warning on line 156 in internal/datastore/mysql/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/mysql/gc.go#L155-L156 

Added lines #L155 - L156 were not covered by tests

Check warning on line 160 in internal/datastore/mysql/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/mysql/gc.go#L159-L160 

Added lines #L159 - L160 were not covered by tests

Check warning on line 224 in internal/datastore/postgres/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/postgres/gc.go#L222-L224 

Added lines #L222 - L224 were not covered by tests

Check warning on line 233 in internal/datastore/postgres/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/postgres/gc.go#L233 

Added line #L233 was not covered by tests

Check warning on line 239 in internal/datastore/postgres/gc.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/postgres/gc.go#L238-L239 

Added lines #L238 - L239 were not covered by tests

Check warning on line 53 in internal/datastore/postgres/locks.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/postgres/locks.go#L52-L53 

Added lines #L52 - L53 were not covered by tests
View more details on Codecov