fix: tighten relationRef anchoring and permission word boundary#69
Merged
miparnisari merged 2 commits intoauthzed:mainfrom May 1, 2026
Merged
Conversation
miparnisari
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related regex-correctness fixes in the permission rule.
1. Anchor
relationRefso it can't shadow arrow rules. It matched any identifier and only worked because the arrow /.any()/.all()rules were listed first in the patterns. Switched to a negative lookahead so it explicitly skips identifiers immediately followed by->,.any(, or.all(— correctness is now regex-local instead of depending on include order. The\bmatters: without it, Oniguruma backtracks\w*into the middle of an identifier when the lookahead fails (matchinggrouforgroup->member).2. Add the missing leading
\bto thepermissionkeyword.definition,relation, andcaveatall start theirbeginregex with\b<keyword>\b;permissionwas the odd one out ((permission\b)). One-character fix for consistency.