feat: Add pre-filter authorization via LookupResources + remove fail_open#4
Open
sohanmaheshwar wants to merge 10 commits intomainfrom
Open
feat: Add pre-filter authorization via LookupResources + remove fail_open#4sohanmaheshwar wants to merge 10 commits intomainfrom
sohanmaheshwar wants to merge 10 commits intomainfrom
Conversation
Removes the fail_open parameter from SpiceDBRetriever, SpiceDBAuthFilter, SpiceDBAuthLambda, SpiceDBAuthTool, create_auth_node, and AuthorizationNode. Also removes fail_open-related tests from unit and integration test suites.
Implements LookupResources streaming API on SpiceDBAuthorizer, enabling pre-filter authorization by returning all resource IDs a subject can access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpiceDBPreFilterRetriever— a newBaseRetrieverthat calls SpiceDB'sLookupResourcesAPI to get authorized resource IDs before querying the vector store, then passes them through a developer-suppliedfilter_factoryintosimilarity_searchfail_openfrom all components (SpiceDBAuthorizer,SpiceDBRetriever,SpiceDBAuthFilter,SpiceDBAuthLambda,SpiceDBAuthTool,create_auth_node,AuthorizationNode) —fail_open=Truepreviously silently granted access to all documents on SpiceDB errors, which is a security violationlookup_resources()toSpiceDBAuthorizeras a reusable core methodBreaking Changes
fail_openparameter removed from all public components (v0.1.0, justified by security)Test Plan
pytest tests/unit_tests/— 43 tests, all passSpiceDBPreFilterRetrieverwith your vector store of choice using afilter_factorymatching its filter syntax (e.g. Pinecone:lambda ids: {"filter": {"article_id": {"$in": ids}}})SpiceDBRetrieverusageexamples/pre_filter_example.pywith a live SpiceDB instance