Clean up of Tier 1 BSP examples#935
Open
kyp44 wants to merge 5 commits into
Open
Conversation
sajattack
force-pushed
the
tier1-bsp-cleanup
branch
from
32ef827 to
f8e54de
Compare
2 tasks
kyp44
force-pushed
the
tier1-bsp-cleanup
branch
from
f8e54de to
54608cf
Compare
kyp44
force-pushed
the
tier1-bsp-cleanup
branch
from
54608cf to
117c5e3
Compare
kyp44
force-pushed
the
tier1-bsp-cleanup
branch
2 times, most recently
from
2ec87d6 to
9e2d2ae
Compare
…HAL to support refactoring the `feather_m0/adalogger` example.
* For the `adalogger` example, fixes a compiler error by upgrading the `embedded-sdmmc` dependency and migrating to the new API. * Fixes a minor compiler error in the `adc` example when the `use_semihosting` feature is enabled. * Fixes a minor compiler warning in the `async_adc` example.
* Fixes a minor compiler warning in the `adc` example. * Fixes a minor compiler warning in the `async_adc` example.
kyp44
force-pushed
the
tier1-bsp-cleanup
branch
from
9e2d2ae to
f07642c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a number of mostly really minor issues with Tier 1 BSP examples that exist in the current
masterbranch.See the commit messages for details about which examples were changed.
Because of the current design of the
usb_devicecrate, examples that use USB across numerous BSPs emit compiler warnings related to having to usestatic mutvariables. Fixing this is more substantial and possibly controversial so will be addressed in a future PR.To address a compiler error, the
feather_m0/adaloggerexample had to be refactored after upgrading theembedded-sdmmcdependency to the latest, incompatible version. If anyone has an Adalogger Feather M0 and can test this, please do so and report in a comment below.Checklist
#[allow]certain lints where reasonable, but ideally justify those with a short comment.