Skip to content

Timer - Fix misuse of ctrlbset and ctrlbclr #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rnd-ash wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Timer - Fix misuse of ctrlbset and ctrlbclr #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hal/src/peripherals/timer/d11.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ where
// need to manually read the bit here
while count.ctrla().read().bits() & 1 != 0 {}

count.ctrlbset().write(|w| {
count.ctrlbclr().write(|w| {
// Count up when the direction bit is zero
w.dir().clear_bit();
w.dir().set_bit();
// Periodic
w.oneshot().clear_bit()
w.oneshot().set_bit()
});

// Set TOP value for mfrq mode
Expand Down
6 changes: 3 additions & 3 deletions hal/src/peripherals/timer/d5x.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ where
count.ctrla().write(|w| w.swrst().set_bit());
while count.syncbusy().read().swrst().bit_is_set() {}

count.ctrlbset().write(|w| {
count.ctrlbclr().write(|w| {
// Count up when the direction bit is zero
w.dir().clear_bit();
w.dir().set_bit();
// Periodic
w.oneshot().clear_bit()
w.oneshot().set_bit()
});

// Set TOP value for mfrq mode
Expand Down