Fix URL prefix matching to require path boundaries#19154
Open
charliermarsh wants to merge 1 commit intomainfrom
Open
Fix URL prefix matching to require path boundaries#19154charliermarsh wants to merge 1 commit intomainfrom
charliermarsh wants to merge 1 commit intomainfrom
Conversation
konstin
reviewed
Apr 25, 2026
| /// | ||
| /// The URL must be in the same realm, or a subdomain of the endpoint realm, and must be under the | ||
| /// endpoint path using complete path-segment prefix matching. | ||
| fn is_endpoint_url(url: &Url, endpoint_url: &Url) -> bool { |
Member
There was a problem hiding this comment.
The main fix looks good, but this part should go into another PR.
Member
Author
There was a problem hiding this comment.
Isn't this the same fix -- just taking the existing check and also requiring that it's a path prefix?
Member
There was a problem hiding this comment.
I see, can you update the PR description to say something about realm vs. URL too? The S3_ENDPOINT_REALM -> S3_ENDPOINT_URL change wasn't clear to me on reading through it, as it didn't do prefix matching in the old version.
konstin
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We're using
url.path().starts_with(self.root_url.path())and similar logic in a few places, which treatshttps://example.com/foobaras a subpath ofhttps://example.com/foo, when these should really be at path boundaries.