Redact sensitive parts of URLs in reqwest errors#19147
Draft
Conversation
zsol
force-pushed
the
zsol/jj-wpzkvnuxrwvr
branch
from
a1f9827 to
441b9fa
Compare
zsol
force-pushed
the
zsol/jj-nnvmtpkulklr
branch
from
1c95afc to
830a963
Compare
zsol
added a commit
that referenced
this pull request
Apr 24, 2026
This teaches `DisplaySafeUrl` about sensitive query parameters (that are typically used to sign S3 requests) to avoid leaking them in verbose logs. Note: Errors might still contain these in two places: - reqwest errors contain a raw url - aws can return an error that itself contains the signature (this is probably fine to display unredacted, as it only happens when the signature is invalid anyway) <!-- start jj-vine stack --> This PR is part of a stack containing 2 PRs: 1. `main` 2. **"Redact pre-signed upload URLs" (this PR)** 3. #19147 <!-- end jj-vine stack -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 2 PRs:
main