Skip to content

Remove xz support entirely#19143

Open
woodruffw wants to merge 1 commit intoww/rm-bz-lzma-in-zipsfrom
ww/rm-xz
Open

Remove xz support entirely#19143
woodruffw wants to merge 1 commit intoww/rm-bz-lzma-in-zipsfrom
ww/rm-xz

Conversation

@woodruffw
Copy link
Copy Markdown
Member

@woodruffw woodruffw commented Apr 24, 2026

Summary

This removes our support for xz decompression entirely, including in the tarball pathway.

WIP. Atop #18927.

Test Plan

Adjust the current tests for new failures.

@woodruffw woodruffw self-assigned this Apr 24, 2026
@woodruffw woodruffw added the breaking A breaking change label Apr 24, 2026
Comment thread Cargo.toml Outdated
Comment on lines +30 to +31
TarGz,
Legacy(LegacySourceDistExtension),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging: this is technically not necessary, but I've done this to provide some more type-level clarity around how sdists are parsed -- we still parse and accept these non-PEP 625 distribution filenames, but we now explicitly bucket them into the Legacy enum to simplify the "this is a legacy behavior" distinction elsewhere.

Comment on lines -86 to -88
// TODO: Remove these other extensions in the future.
// NOTE: These get parsed from network sources like PyPI, so we don't
// necessarily want to hard-fail, just skip in the future.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging: this is done in prioritized_distribution.rs in this PR now 🙂

@woodruffw
Copy link
Copy Markdown
Member Author

Noting: one longer term thing we might want to do here is encode more of this at the type level, i.e. have a SourceDistFilename enum with Pep625(...), Legacy(...) variants. That would IMO make it easier for us to follow through the code and see if there are other places we need to be stricter.

Signed-off-by: William Woodruff <william@astral.sh>
@woodruffw woodruffw marked this pull request as ready for review April 27, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking A breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants