Have verbosity default to level 1 in simulate mode#138
Conversation
Currently, using stow --simulate <package> would normally only output:
WARNING: in simulation mode so not modifying filesystem.
It is generally meant to be used with --verbose for some more more
comprehensive simulation result.
This commit only brings the *default* verbosity to 1 from the generic 0,
but still allows for explicit disabling with --verbosity=0.
Ref: aspiers#82
Reported-by: Ilya Grigoriev <ilyagr@users.noreply.github.com>
Suggested-by: Gutierri Barboza <me@gutierri.me>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughWhen Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@t/cli_options.t`:
- Around line 121-138: The top-level Test::More plan still declares "plan tests
=> 6" but you added a new subtest ("simulate defaults verbosity unless
explicitly set") so update the top-level plan to reflect the new total (change
"plan tests => 6" to "plan tests => 7") or switch to no_plan; locate the
existing plan call (the line containing plan tests => 6) and increment it so the
test harness matches the added subtest that uses process_options().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ec3193da-e253-43f3-81d9-e770f85b7b68
📒 Files selected for processing (2)
bin/stow.int/cli_options.t
f0eea92 to
cdd9282
Compare
Currently, using
stow --simulate <package>would normally only output:It is generally meant to be used with
--verbosefor some more more comprehensive simulation result.This Pull Request only brings the default verbosity to 1 from the generic 0, but still allows for explicit disabling with
--verbosity=0.Also includes some simple test.
Fixes #82.
Summary by CodeRabbit