chore: migrate routing from chi to weby#1390
Open
jrozner wants to merge 1 commit into
Open
Conversation
Replace github.com/go-chi/chi/v5 with github.com/jrozner/weby throughout
the backend. Weby wraps Go 1.22+ stdlib routing (http.ServeMux) and
provides a global middleware stack.
Key changes:
- Entry points (bin/web, bin/api, bin/dev) and integration helpers now
use weby.NewServeMux() with RequestID/WrapResponse/Logger middleware
- server.Web() and server.API() signatures changed from chi.Router to
*http.ServeMux; inner authenticated routes wrapped with per-group
middleware using handler chaining
- Route patterns updated to stdlib "METHOD /path" format; {type:regex}
patterns simplified to {type} (handler already validates values)
- authschemes.AuthScheme.BindRoutes() changed from chi.Router to
*http.ServeMux; all four auth scheme implementations updated
- dissectors.DissectedRequest.FromURL() now uses r.PathValue() instead
of a chi url-param map; constructor signatures simplified accordingly
- Added middleware.InjectLogger() thin wrapper to inject request-scoped
logger into context (used by logging.ReqLogger throughout services)
- Updated dissected_request_test.go to use r.SetPathValue() for URL
param tests
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
@jrozner can you rebase? |
Member
Author
|
I'm going to drop this PR and rewrite it. Would like to leave it up currently for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace github.com/go-chi/chi/v5 with github.com/jrozner/weby throughout the backend. Weby wraps Go 1.22+ stdlib routing (http.ServeMux) and provides a global middleware stack.
Key changes:
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.