use yaml constructors for _IgnoreCustomTagsLoader#1907
Merged
braingram merged 3 commits intoasdf-format:mainfrom Apr 3, 2025
Merged
use yaml constructors for _IgnoreCustomTagsLoader#1907braingram merged 3 commits intoasdf-format:mainfrom
braingram merged 3 commits intoasdf-format:mainfrom
Conversation
Contributor
Author
|
@emolter does this fix the error for you? I tested with the file you shared and with this PR it can be loaded with |
braingram
force-pushed
the
load_yaml_tagged
branch
from
4e2df68 to
41ae78f
Compare
Contributor
Author
|
Romancal regtests (as it uses load_yaml with |
|
Yes this does fix the error for me, thanks Brett |
braingram
force-pushed
the
load_yaml_tagged
branch
from
0b89a85 to
f7f30e4
Compare
braingram
force-pushed
the
load_yaml_tagged
branch
from
f7f30e4 to
fc001f6
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1821
Description
The fix in #1825 was partial (only covering non-tagged nodes) since
construct_mappingis not a generator butconstruct_yaml_mapis).This PR updates
_IgnoreCustomTagsLoaderto useconstruct_yaml_mapandconstruct_yaml_seq(both generators) to handled tagged recursive structures.Tasks
pre-commiton your machinepyteston your machineno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)docs/pagenews fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: bug fixchanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.general.rst: infrastructure or miscellaneous change