Add nightlies to tox and fix Hypothesis test deadline Extended issue#466
Add nightlies to tox and fix Hypothesis test deadline Extended issue#466Sakshee-D wants to merge 6 commits intoarviz-devs:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
==========================================
+ Coverage 85.17% 85.56% +0.39%
==========================================
Files 60 61 +1
Lines 7069 6956 -113
==========================================
- Hits 6021 5952 -69
+ Misses 1048 1004 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
While testing the nightly environment, I observed a As a temporary solution, I can ignore this specific warning so that the nightly tests pass, and follow up with a proper fix later. |
OriolAbril
left a comment
OriolAbril
left a comment
There was a problem hiding this comment.
I will now push the fix for the square root scale issue. Make sure to pull before addressing the review comments.
| py311: python3.11 | ||
| py312: python3.12 | ||
| py313: python3.13 | ||
| nightlies: python3.13 |
There was a problem hiding this comment.
the nightlies job should be added to the list below with python3 only. On Github we only want to run it once, but locally we might want to run it from a different python version. It will also be one less thing to update when updating the python version pin.
There was a problem hiding this comment.
the nighlies job also needs to be added here
| mplstyle.core.reload_library() | ||
| if hasattr(mplstyle, "USER_LIBRARY_PATHS"): | ||
| mplstyle.USER_LIBRARY_PATHS.append(_arviz_style_path) | ||
| elif hasattr(mplstyle, "core") and hasattr(mplstyle.core, "USER_LIBRARY_PATHS"): |
There was a problem hiding this comment.
I would make this an else. We have matplotlib >=3.9 as dependency pin so all versions will have the core module inside styles with this variable. We have had the mplstyle.core.USER... for a while without issues. However, if someone ended up with a broken matplotlib installation the elif could lead to this variable not being updated and harder to track issues when trying to use arviz styles.
| "c": facecolor, | ||
| "color": facecolor, |
There was a problem hiding this comment.
I got an error at some point and changed that, can you check if keeping c the nightlies test still pass? I tried several things to it might be something else I did.
|
It also looks like you'll need to rebase on |
|
I tested |
OriolAbril
left a comment
OriolAbril
left a comment
There was a problem hiding this comment.
However, when running all tests, there are multiple failures ValueErrors (reshape array) unrelated to the "c" change.
I will try to look at this at some point during the week. There might have been a behaviour change in xarray we were not aware was coming. We definitely need to fix these too.
Co-authored-by: Oriol Abril-Pla <oriol.abril.pla@gmail.com>
|
I will also look into the failing tests and trace the chain of failures to see where things are breaking. I will update my findings here. |
|
I looked into the nightly failures. They are caused by a
|
|
Thanks for the fix! |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sakshee-D
force-pushed
the
add-nightlies-tox
branch
from
7935bf5 to
2a07d12
Compare
3 participants
Description
This PR adds a
nightliestest environment intox.inifor arviz-plots.Key Implementation Details
hasattrcheck formplstyle.USER_LIBRARY_PATHShas been added for compatibility with newer versions.DeadlineExceedederror was encountered intests/test_hypothesis_plots.py::test_plot_dgof_dist. This was addressed by adding a@settings(deadline=6000)decorator to the affected test.All tests passed locally.
Closes #453