feat: Add pointwise conditional log-likelihoods for additional distributions#89
Merged
feat: Add pointwise conditional log-likelihoods for additional distributions#89
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 97.04% 97.31% +0.27%
==========================================
Files 16 16
Lines 845 930 +85
==========================================
+ Hits 820 905 +85
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for product distributions, mixture distributions, reshaped distributions, and distributions of joint order statistics. While some of these cases are trivial and others are unlikely to be needed, they make it so that a dependant package can call
pointwise_conditional_loglikelihoodson just about anything a user might try to use as an observation model and it will just work. ™️Motivating example is TuringLang/DynamicPPL.jl#1038
Checklist