Skip to content

fix: Arrow shift method is not handling DST properly #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YousafZahid1 wants to merge 1 commit into from
+6 −4
Closed

fix: Arrow shift method is not handling DST properly #1290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions arrow/arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,7 @@ def shift(self, check_imaginary: bool = True, **kwargs: Any) -> "Arrow":
according to inputs.

Parameters:
check_imaginary (bool): If True (default), will check for and resolve
check_imaginary (bool): If True (default), checks for and resolves
imaginary times (like during DST transitions). If False, skips this check.


Expand Down Expand Up @@ -1048,9 +1048,11 @@ def shift(self, check_imaginary: bool = True, **kwargs: Any) -> "Arrow":

current = self._datetime + relativedelta(**relative_kwargs)

# If check_imaginary is True, perform the check for imaginary times (DST transitions)
if check_imaginary and not dateutil_tz.datetime_exists(current):
current = dateutil_tz.resolve_imaginary(current)
if check_imaginary:
# Check if the resulting datetime exists (not imaginary during DST transition)
if not dateutil_tz.datetime_exists(current):
# Resolve imaginary time by adjusting to the appropriate DST offset
current = dateutil_tz.resolve_imaginary(current)

return self.fromdatetime(current)

Expand Down
Loading