Skip to content

Parse the numeric day-of-week token 'd' #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viraatdas wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

Parse the numeric day-of-week token 'd' #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions arrow/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,7 @@ def _parse_token(
"m",
"ss",
"s",
"d",
"x",
],
value: Union[str, bytes, SupportsInt, bytearray],
Expand Down Expand Up @@ -645,6 +646,9 @@ def _parse_token(
)
parts["day_of_week"] = day_of_week - 1

elif token == "d":
parts["day_of_week"] = int(value) - 1

elif token.upper() in ["HH", "H"]:
parts["hour"] = int(value)

Expand Down
3 changes: 3 additions & 0 deletions tests/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,9 @@ def test_parse_ddd_and_dddd(self):
assert self.parser.parse("Tuesday", "dddd") == expected
assert fr_parser.parse("mardi", "dddd") == expected

# Get first Wednesday after epoch by ISO day of week
assert arrow.get("3", "d") == arrow.get(1970, 1, 7)

# Get first Tuesday in 2020
expected = datetime(2020, 1, 7)
assert self.parser.parse("Tue 2020", "ddd YYYY") == expected
Expand Down
Loading