Skip to content

handle DST properly #1209 #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bingqin2 wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −1
Draft

handle DST properly #1209 #1211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f75f2
handle DST properly #1209
bingqin2 May 20, 2025
c7a3c97
Merge branch 'arrow-py:master' into master
bingqin2 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion arrow/arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,14 @@ def shift(self, check_imaginary: bool = True, **kwargs: Any) -> "Arrow":
relative_kwargs.pop("quarters", 0) * self._MONTHS_PER_QUARTER
)

current = self._datetime + relativedelta(**relative_kwargs)
# current = self._datetime + relativedelta(**relative_kwargs)

@jadchaar jadchaar May 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding unit tests for this?

original_tz = self.tzinfo
if self._datetime.tzinfo is not None:
utc_dt = self._datetime.astimezone(dateutil_tz.UTC)
current = utc_dt + relativedelta(**relative_kwargs)
current = current.astimezone(original_tz)
else:
current = self._datetime + relativedelta(**relative_kwargs)

# If check_imaginary is True, perform the check for imaginary times (DST transitions)
if check_imaginary and not dateutil_tz.datetime_exists(current):
Expand Down
Loading