serial-discovery now talks pluggable discovery protocol v1#1327
Merged
Conversation
silvanocerza
suggested changes
Jun 18, 2021
silvanocerza
left a comment
silvanocerza
left a comment
Contributor
There was a problem hiding this comment.
All in all it's fine for me, but I think debug printing could be done in a better way.
cmaglie
force-pushed
the
pluggable-discovery-3
branch
from
75e09d8 to
6120543
Compare
silvanocerza
approved these changes
Jun 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discovery.Discoveryclass now talks pluggable discovery protocol v1Portfor future useThis change should not break anything.