Skip to content

fix: add <functional> include for std::function usage in example.cpp #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ar90n merged 3 commits into from
May 23, 2025
Merged

fix: add <functional> include for std::function usage in example.cpp #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
790706c
fix: add <functional> include for std::function usage in example.cpp
ar90n May 23, 2025
013b7f2
fix: add <cstdint> include for std::uint64_t usage
ar90n May 23, 2025
2d70e2f
fix: use std::move instead of unqualified move for C++11 compliance
ar90n May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <tuple>
#include <array>
#include <algorithm>
#include <functional>

#include <msgpack11.hpp>

Expand Down
24 changes: 13 additions & 11 deletions msgpack11.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
#include <functional>
#include <stdexcept>
#include <type_traits>
#include <cstdint>
#include <utility>

namespace msgpack11 {

Expand Down Expand Up @@ -384,7 +386,7 @@ class Value : public MsgPackValue {

// Constructors
explicit Value(const T &value) : m_value(value) {}
explicit Value(T &&value) : m_value(move(value)) {}
explicit Value(T &&value) : m_value(std::move(value)) {}

// Get type tag
MsgPack::Type type() const override {
Expand Down Expand Up @@ -627,37 +629,37 @@ class MsgPackString final : public Value<MsgPack::STRING, string> {
const string &string_value() const override { return m_value; }
public:
explicit MsgPackString(const string &value) : Value(value) {}
explicit MsgPackString(string &&value) : Value(move(value)) {}
explicit MsgPackString(string &&value) : Value(std::move(value)) {}
};

class MsgPackArray final : public Value<MsgPack::ARRAY, MsgPack::array> {
const MsgPack::array &array_items() const override { return m_value; }
const MsgPack & operator[](size_t i) const override;
public:
explicit MsgPackArray(const MsgPack::array &value) : Value(value) {}
explicit MsgPackArray(MsgPack::array &&value) : Value(move(value)) {}
explicit MsgPackArray(MsgPack::array &&value) : Value(std::move(value)) {}
};

class MsgPackBinary final : public Value<MsgPack::BINARY, MsgPack::binary> {
const MsgPack::binary &binary_items() const override { return m_value; }
public:
explicit MsgPackBinary(const MsgPack::binary &value) : Value(value) {}
explicit MsgPackBinary(MsgPack::binary &&value) : Value(move(value)) {}
explicit MsgPackBinary(MsgPack::binary &&value) : Value(std::move(value)) {}
};

class MsgPackObject final : public Value<MsgPack::OBJECT, MsgPack::object> {
const MsgPack::object &object_items() const override { return m_value; }
const MsgPack & operator[](const string &key) const override;
public:
explicit MsgPackObject(const MsgPack::object &value) : Value(value) {}
explicit MsgPackObject(MsgPack::object &&value) : Value(move(value)) {}
explicit MsgPackObject(MsgPack::object &&value) : Value(std::move(value)) {}
};

class MsgPackExtension final : public Value<MsgPack::EXTENSION, MsgPack::extension> {
const MsgPack::extension &extension_items() const override { return m_value; }
public:
explicit MsgPackExtension(const MsgPack::extension &value) : Value(value) {}
explicit MsgPackExtension(MsgPack::extension &&value) : Value(move(value)) {}
explicit MsgPackExtension(MsgPack::extension &&value) : Value(std::move(value)) {}
};

class MsgPackNull final : public Value<MsgPack::NUL, NullStruct> {
Expand Down Expand Up @@ -709,16 +711,16 @@ MsgPack::MsgPack(uint32_t value) : m_ptr(make_shared<MsgPackUi
MsgPack::MsgPack(uint64_t value) : m_ptr(make_shared<MsgPackUint64>(value)) {}
MsgPack::MsgPack(bool value) : m_ptr(value ? statics().t : statics().f) {}
MsgPack::MsgPack(const string &value) : m_ptr(make_shared<MsgPackString>(value)) {}
MsgPack::MsgPack(string &&value) : m_ptr(make_shared<MsgPackString>(move(value))) {}
MsgPack::MsgPack(string &&value) : m_ptr(make_shared<MsgPackString>(std::move(value))) {}
MsgPack::MsgPack(const char * value) : m_ptr(make_shared<MsgPackString>(value)) {}
MsgPack::MsgPack(const MsgPack::array &values) : m_ptr(make_shared<MsgPackArray>(values)) {}
MsgPack::MsgPack(MsgPack::array &&values) : m_ptr(make_shared<MsgPackArray>(move(values))) {}
MsgPack::MsgPack(MsgPack::array &&values) : m_ptr(make_shared<MsgPackArray>(std::move(values))) {}
MsgPack::MsgPack(const MsgPack::object &values) : m_ptr(make_shared<MsgPackObject>(values)) {}
MsgPack::MsgPack(MsgPack::object &&values) : m_ptr(make_shared<MsgPackObject>(move(values))) {}
MsgPack::MsgPack(MsgPack::object &&values) : m_ptr(make_shared<MsgPackObject>(std::move(values))) {}
MsgPack::MsgPack(const MsgPack::binary &values) : m_ptr(make_shared<MsgPackBinary>(values)) {}
MsgPack::MsgPack(MsgPack::binary &&values) : m_ptr(make_shared<MsgPackBinary>(move(values))) {}
MsgPack::MsgPack(MsgPack::binary &&values) : m_ptr(make_shared<MsgPackBinary>(std::move(values))) {}
MsgPack::MsgPack(const MsgPack::extension &values) : m_ptr(make_shared<MsgPackExtension>(values)) {}
MsgPack::MsgPack(MsgPack::extension &&values) : m_ptr(make_shared<MsgPackExtension>(move(values))) {}
MsgPack::MsgPack(MsgPack::extension &&values) : m_ptr(make_shared<MsgPackExtension>(std::move(values))) {}

/* * * * * * * * * * * * * * * * * * * *
* Accessors
Expand Down