[SC-37908] Remove http+elb code - #73
Merged
Merged
Conversation
UserNotFound
changed the title
UserNotFound
marked this pull request as ready for review
June 12, 2026 20:39
UserNotFound
force-pushed
the
remove-elb-code
branch
from
June 12, 2026 21:20
a9da3b4 to
522f6b0
Compare
madhuravius
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This accomplishes a few things, mainly centered around deprecating ELB-based http endpoints, and the type
http_proxy_protocolthat was used for them.This client and our TF provide only create ALB-based http endpoints, and should have never created them as
http_proxy_protocol, but ratherhttp, as this change implements.It this client an our TF provider couldn't import existing
type: "http"endpoints, which all client should create. We need to at least temporarily (until all vhost in the API are changed) accept both http and http_proxy_protocol. Solve this issue: aptible/terraform-provider-aptible#179Finally, I updated the user agent string so that instead of the generic
OpenAPI-Generator/1.0.0/gowe getaptible/go-deploy/v0.5.5Then, i had to bump the go version, test tool versions to a version that support arm so i can test on my laptop, fix a decade's worth of whitespacing formatting errors, and remove a deprecated module that doesn't have support for typechecking in the linter...