Add nsys profile plotter and improve documentation#643
Conversation
SeverinDiederichs
added
the
documentation
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Can one of the admins verify this patch? |
|
@codex review |
|
/run-test |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18eb8ce11d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ax.pie(values, labels=[f"{label}\n{pct(transport_by_particle[label], transport_ns):.1f}%" for label in labels], | ||
| startangle=90, textprops={"fontsize": 9}) |
There was a problem hiding this comment.
If the captured range has no matching transport kernels (e.g., short or mis-scoped nsys capture), values becomes all zeros and transport_ns is zero, but this block still calls ax.pie(...). Axes.pie normalizes by sum(x), so a zero-sum pie can fail at runtime and abort the script before writing plots/summaries. Add the same kind of empty-data guard used in draw_pie (render a placeholder text instead of calling pie when the total is zero).
Useful? React with 👍 / 👎.
|
/run-test |
|
/run-test |
agheata
left a comment
agheata
left a comment
There was a problem hiding this comment.
Thanks for the nice addition!
3 participants
This PR adds a plotting script to get useful performance profiling plots out of
nsys. It documents how to use and interpret the data.Current plots from runs in Athena:
Current plots from runs with CMSSW
Current plots from runs with LHCb
