fix: ensure Get Started button is fully visible in hero section (fixes #300)#362
fix: ensure Get Started button is fully visible in hero section (fixes #300)#362sainimanguu wants to merge 1 commit intoapsinghdev:mainfrom
Conversation
|
@sainimanguu is attempting to deploy a commit to the AJEET PRATAP SINGH's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Hero section container's Tailwind CSS sizing on large screens was adjusted from a fixed height ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Here is a PR description you can copy and paste into GitHub when creating the Pull Request:
Description
Fixes #300
This PR addresses an issue where the primary "Get Started" CTA button in the hero section is partially hidden or cut off on smaller screens or at 100% zoom.
Cause
The root of the issue was a combination of
overflow-hiddenand a strict viewport heightlg:h-[75dvh]on the Hero section container. If the content height natively exceeds 75% of the viewport (which happens easily vertically on laptops, especially with the large typography), the bottom elements overflowed and were clipped, hiding the CTA button.Changes Made
apps/web/src/components/landing-sections/Hero.tsxlg:h-[75dvh]constraint withlg:min-h-[75dvh].Testing Instructions
/.Summary by CodeRabbit