Skip to content

fix: ensure Get Started button is fully visible in hero section (fixes #300)#362

Open
sainimanguu wants to merge 1 commit intoapsinghdev:mainfrom
sainimanguu:fix/issue-300
Open

fix: ensure Get Started button is fully visible in hero section (fixes #300)#362
sainimanguu wants to merge 1 commit intoapsinghdev:mainfrom
sainimanguu:fix/issue-300

Conversation

@sainimanguu
Copy link
Copy Markdown

@sainimanguu sainimanguu commented Apr 19, 2026

Here is a PR description you can copy and paste into GitHub when creating the Pull Request:


Description

Fixes #300

This PR addresses an issue where the primary "Get Started" CTA button in the hero section is partially hidden or cut off on smaller screens or at 100% zoom.

Cause

The root of the issue was a combination of overflow-hidden and a strict viewport height lg:h-[75dvh] on the Hero section container. If the content height natively exceeds 75% of the viewport (which happens easily vertically on laptops, especially with the large typography), the bottom elements overflowed and were clipped, hiding the CTA button.

Changes Made

  • Updated apps/web/src/components/landing-sections/Hero.tsx
  • Replaced the strict lg:h-[75dvh] constraint with lg:min-h-[75dvh].
  • This ensures the Hero component still maintains the expected optimal baseline layout height on tall screens, while allowing the container to dynamically expand vertically for smaller screens, securing full visibility of the "Get Started" button.

Testing Instructions

  1. Navigate to the landing page at index /.
  2. Inspect the Hero section down smaller breakpoints and viewport heights.
  3. Validate that the "Get Started" button remains fully visible and interactive at the bottom of the section without getting clipped.

Summary by CodeRabbit

  • Style
    • Adjusted Hero section layout on large screens to allow for dynamic height based on content requirements rather than a fixed height.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 19, 2026

@sainimanguu is attempting to deploy a commit to the AJEET PRATAP SINGH's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ec1a960e-0ca8-4f34-986c-374a42084364

📥 Commits

Reviewing files that changed from the base of the PR and between a2ef5f3 and 6d9a6ab.

📒 Files selected for processing (1)
  • apps/web/src/components/landing-sections/Hero.tsx

📝 Walkthrough

Walkthrough

The Hero section container's Tailwind CSS sizing on large screens was adjusted from a fixed height (lg:h-[75dvh]) to a minimum height (lg:min-h-[75dvh]), enabling the section to expand vertically when content requires additional space.

Changes

Cohort / File(s) Summary
Hero Section Layout Adjustment
apps/web/src/components/landing-sections/Hero.tsx
Changed large-screen container from fixed height to minimum height to accommodate full content visibility.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A button was hidden, oh what a plight!
The hero grew rigid, not quite tall enough bright.
Now min-height stretches to let content breathe free,
No more clipped CTAs—visibility decree! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the visibility of the Get Started button in the hero section, with reference to the issue being resolved.
Linked Issues check ✅ Passed The code change directly addresses issue #300 by replacing lg:h-[75dvh] with lg:min-h-[75dvh], allowing the hero section to expand and prevent button clipping as required.
Out of Scope Changes check ✅ Passed The change is limited to a single Tailwind CSS property modification in the Hero component, directly scoped to fix the visibility issue without introducing unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant