Use OpenAPIKit for more validation logic#880
Merged
Merged
Conversation
mattpolzin
force-pushed
the
upstream-validation
branch
from
0d88cf4 to
59eecdb
Compare
Collaborator
|
Realise this is backing off another WIP PR but, after a preliminary glance, this seems like a win to me—thanks! |
mattpolzin
force-pushed
the
upstream-validation
branch
from
59eecdb to
d06ba71
Compare
mattpolzin
force-pushed
the
upstream-validation
branch
from
d06ba71 to
04e20aa
Compare
mattpolzin
commented
May 12, 2026
Contributor
Author
|
@simonjbeaumont absolutely no hurry on this PR, but I wanted to ping you since I left it open for quite a while as a draft but it has now been rebased against latest |
Collaborator
|
@mattpolzin amazing, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OpenAPIKit provides some validation help in its latest versions that can be used here to reduce the amount of logic this project must maintain. For example, the generator need not crawl the document to validate all content types, this is the behavior of a
Validation<OpenAPIKit.ContentType>.Modifications
ContentTypecheck with one using OpenAPIKit's validation DSL. This mostly serves to avoid the need to maintain logic in this library that OpenAPIKit must maintain anyway (namely, there's no need to find theContentTypevalues to validate them, OpenAPIKit will validate all values of that type anywhere in the Document).Result
Removed code, slightly different error messages.
Test Plan
Tests have been updated to reflect the new (though comparable) errors.